Feature/plmc 262 update to 0943 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrazovic
commented
Sep 5, 2023
Comment on lines
193
to
195
| fn contains(id: &<Assets as fungibles::Inspect<AccountId>>::AssetId) -> bool { | ||
| !Assets::total_issuance(*id).is_zero() | ||
| !Assets::total_issuance(id.clone()).is_zero() | ||
| } |
There was a problem hiding this comment.
Coming from the Parachain Template.
Comment on lines
310
to
320
| impl Reserve for MultiAsset { | ||
| fn reserve(&self) -> Option<MultiLocation> { | ||
| if let AssetId::Concrete(location) = self.id.clone() { | ||
| if let AssetId::Concrete(location) = self.id { | ||
| let first_interior = location.first_interior(); | ||
| let parents = location.parent_count(); | ||
| match (parents, first_interior.clone()) { | ||
| (0, Some(Parachain(id))) => Some(MultiLocation::new(0, X1(Parachain(id.clone())))), | ||
| (1, Some(Parachain(id))) => Some(MultiLocation::new(1, X1(Parachain(id.clone())))), | ||
| match (parents, first_interior) { | ||
| (0, Some(Parachain(id))) => Some(MultiLocation::new(0, X1(Parachain(*id)))), | ||
| (1, Some(Parachain(id))) => Some(MultiLocation::new(1, X1(Parachain(*id)))), | ||
| (1, _) => Some(MultiLocation::parent()), | ||
| _ => None, | ||
| } |
There was a problem hiding this comment.
Coming from the Cumulus Repository (Penpal Runtime).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try-runtimefeature is now possible, all the packages now use the correct set of features. Thanks to https://github.com/ggwpez/zepterTODO
xcm-emulatorfrom the Cumulus (PolkadotSDK after the 1.0.0 update) repository. The syntax is slightly different (example: https://github.com/paritytech/polkadot-sdk/blob/336916827f78a320fddbf1925984ec0a1f884376/cumulus/parachains/integration-tests/emulated/common/src/lib.rs#L36). We will update the syntax in another PR later on.