Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iv benchamerks 28 #579

Merged
merged 56 commits into from
Nov 1, 2022
Merged

Iv benchamerks 28 #579

merged 56 commits into from
Nov 1, 2022

Conversation

35359595
Copy link
Contributor

@35359595 35359595 commented Oct 20, 2022

Describe your changes

  • fixed logic of claim_withdraw and register_enclave so benchmarks can work with those;
  • refactored dependencies - now all versions in two places: root Cargo.toml or node/Cargo.toml;
  • fixed build of --features runtime-benchmarks;
  • fixed missing pallets in std feature of runtime;
  • implemented missing benchmarks for asset-handler pallet;
  • generated weights for both pallets on dedicated VM;
  • new weight annotations using outputs from actual benchmarking;
  • removed commenting symbol from benchmark build command in CI;

Issue ticket number and link

Closes #435
Closes #493
Closes #481
Closes #539
Closes #561

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@35359595 35359595 added the A0-PleaseReview Pull request needs code review. label Oct 20, 2022
pallets/asset-handler/rpc/Cargo.toml Show resolved Hide resolved
pallets/asset-handler/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/asset-handler/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/asset-handler/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/asset-handler/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/pdex-migration/src/benchmarking.rs Show resolved Hide resolved
runtime/Cargo.toml Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait on fix from devops team to pass CI

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 55.48% // Head: 54.32% // Decreases project coverage by -1.16% ⚠️

Coverage data is based on head (528949e) compared to base (0c0dfc1).
Patch coverage: 21.73% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #579      +/-   ##
===========================================
- Coverage    55.48%   54.32%   -1.17%     
===========================================
  Files           20       20              
  Lines         1395     1434      +39     
===========================================
+ Hits           774      779       +5     
- Misses         621      655      +34     
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <ø> (ø)
pallets/asset-handler/rpc/src/lib.rs 0.00% <ø> (ø)
pallets/asset-handler/src/benchmarking.rs 0.00% <ø> (ø)
pallets/asset-handler/src/lib.rs 73.14% <0.00%> (-0.85%) ⬇️
pallets/asset-handler/src/weights.rs 0.00% <0.00%> (ø)
pallets/chainbridge/src/lib.rs 80.28% <ø> (ø)
pallets/ocex/src/benchmarking.rs 0.00% <0.00%> (ø)
pallets/ocex/src/weights.rs 0.00% <0.00%> (ø)
pallets/pdex-migration/src/lib.rs 81.08% <ø> (ø)
runtime/src/lib.rs 0.00% <ø> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gauthamastro Gauthamastro merged commit d33c4fe into Develop Nov 1, 2022
@Gauthamastro Gauthamastro deleted the iv-benchamerks-28 branch November 1, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
3 participants