Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset handler tests improvement #602

Merged
merged 5 commits into from Jan 12, 2023

Conversation

serhii-temchenko
Copy link
Contributor

In this PR:

  • Common implementation in thea related tests moved to separate private functions to be reused.
  • Extended amount of tests to cover more cases
  • Added functions with todo's inside for missing cases

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 53.79% // Head: 54.24% // Increases project coverage by +0.44% 🎉

Coverage data is based on head (d851dab) compared to base (dc169e4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           fx-asset-handler     #602      +/-   ##
====================================================
+ Coverage             53.79%   54.24%   +0.44%     
====================================================
  Files                    20       20              
  Lines                  1461     1462       +1     
====================================================
+ Hits                    786      793       +7     
+ Misses                  675      669       -6     
Impacted Files Coverage Δ
pallets/asset-handler/src/lib.rs 76.09% <100.00%> (+3.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felixfaisal felixfaisal merged commit 1a21c5c into fx-asset-handler Jan 12, 2023
@felixfaisal felixfaisal deleted the asset-handler-tests-improvement branch January 12, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants