Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases for V2 #675

Merged
merged 18 commits into from Mar 31, 2023
Merged

Test cases for V2 #675

merged 18 commits into from Mar 31, 2023

Conversation

nakul1010
Copy link
Contributor

@nakul1010 nakul1010 commented Mar 23, 2023 •
edited by serhii-temchenko

Partially resolves 703

  • register_main
    • Access to DB
  • add_proxy
    • Access to DB
  • remove_proxy
    • Access to DB
  • deposit
    • Access to DB
  • process_trade
    • Access to DB
  • process_chunk
  • store_snapshot
  • load_snapshot
  • add_balance
  • sub_balance

@nakul1010 nakul1010 added the A3-InProgress Pull request is in progress. No review needed at this stage. label Mar 23, 2023
@nakul1010 nakul1010 self-assigned this Mar 23, 2023
@nakul1010 nakul1010 added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Mar 24, 2023
@nakul1010 nakul1010 changed the title Test ceses for V2 Test cases for V2 Mar 24, 2023
@nakul1010
Copy link
Contributor Author

nakul1010 commented Mar 27, 2023 •
edited

@Gauthamastro CI is failing for the base branch(gj-ob) hence will fail for the current branch as well. OCEX pallet needs to be fixed.

@nakul1010 nakul1010 assigned nakul1010 and zktony and unassigned nakul1010 Mar 27, 2023
serhii-temchenko
serhii-temchenko requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gauthamastro CI is failing for the base branch(gj-ob) hence will fail for the current branch as well. OCEX pallet needs to be fixed.

Could base branch be fixed before merging something else to not multiply potential problems in one branch? Especially when this PR supposed to fix tests - we have test build fail...

@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited

Codecov Report

Patch coverage: 66.66% and project coverage change: +6.86 🎉

Comparison is base (7f978eb) 22.88% compared to head (207f134) 29.75%.

Additional details and impacted files 
@@            Coverage Diff             @@
##            gj-ob     #675      +/-   ##
==========================================
+ Coverage   22.88%   29.75%   +6.86%     
==========================================
  Files          60       59       -1     
  Lines        3915     3919       +4     
==========================================
+ Hits          896     1166     +270     
+ Misses       3019     2753     -266
Impacted Files Coverage Δ
clients/orderbook/src/error.rs 0.00% <ø> (ø)
clients/orderbook/src/lib.rs 42.42% <ø> (+42.42%) ⬆️
clients/orderbook/src/worker.rs 31.05% <66.66%> (+31.05%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nakul1010 nakul1010 merged commit b3b3ab8 into gj-ob Mar 31, 2023
3 checks passed
@nakul1010 nakul1010 deleted the nap-v2-test-ob branch March 31, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

@zktony zktony Awaiting requested review from zktony

@Gauthamastro Gauthamastro Awaiting requested review from Gauthamastro

Assignees

@nakul1010 nakul1010

@zktony zktony

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nakul1010 @Gauthamastro @serhii-temchenko @zktony