Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI node artifact #679

Merged
merged 7 commits into from Mar 28, 2023
Merged

CI node artifact #679

merged 7 commits into from Mar 28, 2023

Conversation

serhii-temchenko
Copy link
Contributor

In this PR in the CI added node compiled binary as an artifact to be fetched from other repositories for the testing purpose. This changes reduces e2e execution time on ~7 minutes (which is ~27%).

Related to PR 748.

@serhii-temchenko serhii-temchenko added the A0-PleaseReview Pull request needs code review. label Mar 27, 2023
@serhii-temchenko serhii-temchenko self-assigned this Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (209057a) 47.11% compared to head (0ce52a9) 47.11%.

Additional details and impacted files
@@           Coverage Diff            @@
##           Develop     #679   +/-   ##
========================================
  Coverage    47.11%   47.11%           
========================================
  Files           37       37           
  Lines         2812     2812           
========================================
  Hits          1325     1325           
  Misses        1487     1487           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhii-temchenko serhii-temchenko merged commit f00986e into Develop Mar 28, 2023
3 checks passed
@serhii-temchenko serhii-temchenko deleted the ci-node-artifact branch March 28, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants