Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process withdrawals from Snapshot #687

Merged
merged 3 commits into from Apr 1, 2023
Merged

Process withdrawals from Snapshot #687

merged 3 commits into from Apr 1, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Mar 30, 2023

Describe your changes

Process withdrawals from Snapshot.

Issue ticket number and link

Will close https://github.com/Polkadex-Substrate/orderbook/issues/755

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (gj-ob@7ccfa04). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             gj-ob     #687   +/-   ##
========================================
  Coverage         ?   29.04%           
========================================
  Files            ?       59           
  Lines            ?     4059           
  Branches         ?        0           
========================================
  Hits             ?     1179           
  Misses           ?     2880           
  Partials         ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

clients/orderbook/src/worker.rs Outdated Show resolved Hide resolved
pallets/ocex/src/lib.rs Outdated Show resolved Hide resolved
pallets/ocex/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pallets/ocex/src/lib.rs Show resolved Hide resolved
pallets/ocex/src/lib.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants