Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Substrate version to v0.9.37 #701

Merged
merged 28 commits into from Apr 8, 2023
Merged

Updates Substrate version to v0.9.37 #701

merged 28 commits into from Apr 8, 2023

Conversation

Gauthamastro
Copy link
Member

@Gauthamastro Gauthamastro commented Apr 6, 2023 •
edited by 35359595

TODO:

    • Execute and update weights in all pallets
    • Fix thea pallet tests.
    • Thea staking contains todo!() for StakingInterface

@Gauthamastro Gauthamastro added benchmarking A3-InProgress Pull request is in progress. No review needed at this stage. labels Apr 6, 2023
@Gauthamastro
Merge branch 'Develop' into gj-substrate-upgrade
82b3aa6 
# Conflicts:
#	Cargo.lock
#	clients/orderbook/src/lib.rs
#	node/Cargo.toml
#	primitives/polkadex/src/ocex.rs
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: -7.34 ⚠️

Comparison is base (6f92ee1) 47.91% compared to head (01c0e07) 40.57%.

❗ Current head 01c0e07 differs from pull request most recent head 1a28338. Consider uploading reports for the commit 1a28338 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           Develop     #701      +/-   ##
===========================================
- Coverage    47.91%   40.57%   -7.34%     
===========================================
  Files           61       59       -2     
  Lines         4385     4303      -82     
===========================================
- Hits          2101     1746     -355     
- Misses        2284     2557     +273

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

zktony and others added 17 commits April 7, 2023 11:08
@35359595 35359595 self-requested a review April 7, 2023 21:51
@35359595 35359595 added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Apr 7, 2023
@35359595
Copy link
Contributor

35359595 commented Apr 7, 2023

@Gauthamastro take another look and let me know when to approve - you can not be a reviewer of your own PR...

Gauthamastro
Gauthamastro commented Apr 8, 2023
View reviewed changes
Copy link
Member Author

@Gauthamastro Gauthamastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, merging.

@Gauthamastro Gauthamastro merged commit 5544ed0 into Develop Apr 8, 2023
2 of 3 checks passed
@Gauthamastro Gauthamastro deleted the gj-substrate-upgrade branch April 8, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhii-temchenko serhii-temchenko Awaiting requested review from serhii-temchenko

@35359595 35359595 Awaiting requested review from 35359595

Assignees

@35359595 35359595

Labels
A0-PleaseReview Pull request needs code review. benchmarking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gauthamastro @35359595 @zktony @serhii-temchenko