Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iv 50 swap tnb #705

Merged
merged 5 commits into from Apr 12, 2023
Merged

Iv 50 swap tnb #705

merged 5 commits into from Apr 12, 2023

Conversation

35359595
Copy link
Contributor

@35359595 35359595 commented Apr 10, 2023

Describe your changes

Tests and benchmarks for pallet_amm
Weights generated on dedicated server

Issue ticket number and link

#50 from thea

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@35359595 35359595 added the A0-PleaseReview Pull request needs code review. label Apr 10, 2023
@35359595 35359595 self-assigned this Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +6.36 🎉

Comparison is base (54a3df1) 42.12% compared to head (3595821) 48.49%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #705      +/-   ##
===========================================
+ Coverage    42.12%   48.49%   +6.36%     
===========================================
  Files           60       62       +2     
  Lines         5073     5110      +37     
===========================================
+ Hits          2137     2478     +341     
+ Misses        2936     2632     -304     
Impacted Files Coverage Δ
pallets/swap/src/benchmarking.rs 0.00% <0.00%> (ø)
pallets/swap/src/lib.rs 62.62% <0.00%> (+62.62%) ⬆️
pallets/swap/src/weights.rs 0.00% <0.00%> (ø)
runtime/src/lib.rs 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gauthamastro Gauthamastro merged commit ae0e998 into Develop Apr 12, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the iv-50-swap-tnb branch April 12, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants