Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed todos and added claim_deposit ext #707

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Fixed todos and added claim_deposit ext #707

merged 9 commits into from
Apr 19, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Apr 13, 2023 •
edited
Loading

Describe your changes

  • Fixed todos and added claim_deposit ext.
  • Added test cases.

@zktony zktony assigned Gauthamastro and unassigned Gauthamastro Apr 13, 2023
@zktony zktony added the A0-PleaseReview Pull request needs code review. label Apr 19, 2023
@serhii-temchenko serhii-temchenko dismissed their stale review April 19, 2023 09:16

CI is failing, please fix build

@Gauthamastro
Copy link
Member

@serhii-temchenko I am merging this to my branch, and you can review it in my PR.

@Gauthamastro Gauthamastro merged commit b18f0c2 into gj-thea-client Apr 19, 2023
2 of 3 checks passed
@Gauthamastro Gauthamastro deleted the zk-refactor-thea-exc branch April 19, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

@serhii-temchenko serhii-temchenko serhii-temchenko left review comments

@nuel77 nuel77 Awaiting requested review from nuel77

Assignees
No one assigned
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zktony @Gauthamastro @serhii-temchenko