Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot interval defaults to 20 withdrawals or 5 blocks ( ~ 1 min ) #722

Merged
merged 3 commits into from Apr 20, 2023

Conversation

Gauthamastro
Copy link
Member

@Gauthamastro Gauthamastro commented Apr 20, 2023

The snapshot interval was defaulting to 0 withdrawals and 0 blocks which is wrong.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (14aef52) 48.11% compared to head (ab23158) 48.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #722      +/-   ##
===========================================
- Coverage    48.11%   48.10%   -0.01%     
===========================================
  Files           65       65              
  Lines         4951     4952       +1     
===========================================
  Hits          2382     2382              
- Misses        2569     2570       +1     
Impacted Files Coverage Δ
pallets/ocex/src/lib.rs 61.08% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gauthamastro Gauthamastro merged commit 7f2e3f1 into Develop Apr 20, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the gj/default-intervals branch April 20, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants