Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changelog #747

Merged
merged 2 commits into from May 16, 2023
Merged

Added changelog #747

merged 2 commits into from May 16, 2023

Conversation

serhii-temchenko
Copy link
Contributor

Added release notes (changelog) to track changes presented in a new releases. Currently covers new future changes in an new release.

FYI @pavankanteti

@serhii-temchenko serhii-temchenko added the A0-PleaseReview Pull request needs code review. label May 12, 2023
@serhii-temchenko serhii-temchenko self-assigned this May 12, 2023
@Gauthamastro
Copy link
Member

@serhii-temchenko, thanks a lot for this. This is epic!!

@serhii-temchenko
Copy link
Contributor Author

serhii-temchenko commented May 15, 2023

FYI Fixes, related to the CI failing - should be resolved in the scope of issue #744.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -4.96 ⚠️

Comparison is base (2131cb1) 48.00% compared to head (222e637) 43.05%.

❗ Current head 222e637 differs from pull request most recent head 6ffe775. Consider uploading reports for the commit 6ffe775 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #747      +/-   ##
===========================================
- Coverage    48.00%   43.05%   -4.96%     
===========================================
  Files           63       62       -1     
  Lines         4968     4801     -167     
===========================================
- Hits          2385     2067     -318     
- Misses        2583     2734     +151     
Impacted Files Coverage Δ
clients/orderbook/src/lib.rs 48.57% <ø> (-1.43%) ⬇️
clients/thea/src/gossip.rs 0.00% <0.00%> (-17.03%) ⬇️
clients/thea/src/keystore.rs 0.00% <ø> (-57.90%) ⬇️
clients/thea/src/lib.rs 0.00% <0.00%> (ø)
clients/thea/src/worker.rs 0.00% <0.00%> (-63.06%) ⬇️
node/src/rpc.rs 0.00% <0.00%> (ø)
pallets/asset-handler/src/benchmarking.rs 0.00% <ø> (ø)
pallets/asset-handler/src/lib.rs 61.36% <ø> (-5.84%) ⬇️
pallets/ocex/src/benchmarking.rs 0.00% <ø> (ø)
primitives/bls-primitives/src/lib.rs 56.36% <ø> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gauthamastro Gauthamastro merged commit 167f81b into Develop May 16, 2023
2 checks passed
@Gauthamastro Gauthamastro deleted the changelog branch May 16, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants