Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added thea-executor benchmark #802

Merged
merged 15 commits into from
Jun 20, 2023
Merged

Added thea-executor benchmark #802

merged 15 commits into from
Jun 20, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Jun 15, 2023

Describe your changes

Added thea-executor benchmark.

@zktony zktony requested a review from Gauthamastro June 15, 2023 20:37
Copy link
Member

@Gauthamastro Gauthamastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix that TODO, rest looks okay.

35359595
35359595 previously approved these changes Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 12.82% and project coverage change: -0.21 ⚠️

Comparison is base (48b58d5) 32.38% compared to head (276fad3) 32.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #802      +/-   ##
===========================================
- Coverage    32.38%   32.17%   -0.21%     
===========================================
  Files           62       64       +2     
  Lines         4336     4373      +37     
===========================================
+ Hits          1404     1407       +3     
- Misses        2932     2966      +34     
Impacted Files Coverage Δ
pallets/thea-executor/src/benchmarking.rs 0.00% <0.00%> (ø)
pallets/thea-executor/src/weights.rs 0.00% <0.00%> (ø)
runtime/src/lib.rs 0.00% <ø> (ø)
pallets/thea-executor/src/lib.rs 63.23% <100.00%> (+0.27%) ⬆️
primitives/polkadex/src/assets.rs 56.14% <100.00%> (+1.59%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

35359595
35359595 previously approved these changes Jun 16, 2023
Gauthamastro added a commit that referenced this pull request Jun 19, 2023
## Describe your changes
Benchmarks generated for all pallets, except those in separate PRs:
#802 
#805 

## Checklist before requesting a review
- [x] I have performed a self-review of my code.
- [x] If it is a core feature, I have added thorough tests.
- [x] I removed all Clippy and Formatting Warnings. 
- [x] I added required Copyrights.
@Gauthamastro Gauthamastro merged commit 37e2c55 into Develop Jun 20, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the zk-benchmark-43 branch June 20, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants