Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iv thea pallet tests #812

Merged
merged 16 commits into from
Jun 21, 2023
Merged

Iv thea pallet tests #812

merged 16 commits into from
Jun 21, 2023

Conversation

35359595
Copy link
Contributor

@35359595 35359595 commented Jun 20, 2023 •
edited

Describe your changes

All extrinsics success and bad inputs tests

Issue ticket number and link

#810

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@35359595 35359595 linked an issue Jun 20, 2023 that may be closed by this pull request
Test Cases - Thea Pallet #810
Closed
@35359595 35359595 self-assigned this Jun 20, 2023
@35359595 35359595 added the A0-PleaseReview Pull request needs code review. label Jun 20, 2023
serhii-temchenko
serhii-temchenko requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI errors.

pallets/thea/src/tests.rs Outdated Show resolved Hide resolved
pallets/thea/src/tests.rs Outdated Show resolved Hide resolved
pallets/thea/src/tests.rs Show resolved Hide resolved
serhii-temchenko and others added 5 commits June 20, 2023 20:35
@serhii-temchenko
Merge branch 'Develop' into iv-thea-pallet-tests
77a37cc
@35359595
mock alligned
c0b8f41
@35359595 @serhii-temchenko
Update pallets/thea/src/tests.rs
0f29973 
Co-authored-by: serhii-temchenko <107397548+serhii-temchenko@users.noreply.github.com>
@35359595 @serhii-temchenko
Update pallets/thea/src/tests.rs
3aa1c40 
Co-authored-by: serhii-temchenko <107397548+serhii-temchenko@users.noreply.github.com>
@35359595 @serhii-temchenko
Update pallets/thea/src/tests.rs
8f5d6fd 
Co-authored-by: serhii-temchenko <107397548+serhii-temchenko@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.68 🎉

Comparison is base (37e2c55) 32.13% compared to head (8f5d6fd) 33.82%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           Develop     #812      +/-   ##
===========================================
+ Coverage    32.13%   33.82%   +1.68%     
===========================================
  Files           64       64              
  Lines         4381     4381              
===========================================
+ Hits          1408     1482      +74     
+ Misses        2973     2899      -74
Impacted Files Coverage Δ
pallets/thea/src/benchmarking.rs 0.00% <ø> (ø)
pallets/thea/src/lib.rs 43.05% <ø> (+43.05%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@serhii-temchenko serhii-temchenko merged commit 5b028d7 into Develop Jun 21, 2023
3 checks passed
@serhii-temchenko serhii-temchenko deleted the iv-thea-pallet-tests branch June 21, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

Assignees

@35359595 35359595

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Cases - Thea Pallet
3 participants
@35359595 @Gauthamastro @serhii-temchenko