Drop Gossip messages on Thea auth wait loop #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## Develop #818 +/- ##
===========================================
- Coverage 33.82% 33.75% -0.07%
===========================================
Files 64 64
Lines 4381 4390 +9
===========================================
Hits 1482 1482
- Misses 2899 2908 +9
☔ View full report in Codecov by Sentry. |
35359595
approved these changes
Jun 21, 2023
serhii-temchenko
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Runtime upgrade started the Thea's authority wait-loop, which doesn't consume the gossip message stream; the Substrate internally clones all messages irrespective of the consumer. It is necessary to drop those messages while waiting to avoid memory blowup.