Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored offichain worker code for both Thea and Ocex Pallets #863

Merged
merged 20 commits into from
Sep 4, 2023
Merged

Refactored offichain worker code for both Thea and Ocex Pallets #863

merged 20 commits into from
Sep 4, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Aug 17, 2023

Describe your changes

Refactored offichain worker code for both Thea and Ocex Pallets.

@zktony zktony changed the base branch from mainnet-release to Develop August 17, 2023 18:07
@zktony zktony added the A0-PleaseReview Pull request needs code review. label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited

Codecov Report

Patch coverage: 0.83% and project coverage change: -1.37% ⚠️

Comparison is base (04c2825) 38.48% compared to head (79853e5) 37.12%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           Develop     #863      +/-   ##
===========================================
- Coverage    38.48%   37.12%   -1.37%     
===========================================
  Files           49       53       +4     
  Lines         3079     3184     +105     
===========================================
- Hits          1185     1182       -3     
- Misses        1894     2002     +108
Files Changed Coverage Δ
node/src/rpc.rs 0.00% <0.00%> (ø)
pallets/ocex/rpc/runtime-api/src/lib.rs 0.00% <ø> (ø)
pallets/ocex/rpc/src/lib.rs 0.00% <0.00%> (ø)
pallets/ocex/rpc/src/offchain.rs 0.00% <0.00%> (ø)
pallets/ocex/src/aggregator.rs 0.00% <0.00%> (ø)
pallets/ocex/src/lib.rs 69.25% <0.00%> (-2.15%) ⬇️
pallets/ocex/src/rpc.rs 0.00% <ø> (ø)
pallets/ocex/src/storage.rs 75.60% <ø> (ø)
pallets/thea/src/aggregator.rs 0.00% <0.00%> (ø)
pallets/thea/src/lib.rs 64.40% <ø> (ø)
... and 5 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serhii-temchenko serhii-temchenko mentioned this pull request Aug 19, 2023
Closed
serhii-temchenko
serhii-temchenko requested changes Aug 19, 2023
View reviewed changes
pallets/ocex/src/aggregator.rs Outdated Show resolved Hide resolved
pallets/ocex/src/validator.rs Show resolved Hide resolved
pallets/thea/src/aggregator.rs Outdated Show resolved Hide resolved
pallets/thea/src/resolver.rs Outdated Show resolved Hide resolved
Gauthamastro
Gauthamastro requested changes Aug 31, 2023
View reviewed changes
pallets/ocex/rpc/src/lib.rs Outdated Show resolved Hide resolved
pallets/thea/src/validation.rs Show resolved Hide resolved
primitives/orderbook/src/lib.rs Outdated Show resolved Hide resolved
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Sep 1, 2023
serhii-temchenko
serhii-temchenko requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI errors

pallets/ocex/rpc/src/offchain.rs Outdated Show resolved Hide resolved
pallets/thea/src/aggregator.rs Outdated Show resolved Hide resolved
pallets/thea/src/resolver.rs Outdated Show resolved Hide resolved
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Sep 4, 2023
@Gauthamastro Gauthamastro merged commit 6ad911e into Develop Sep 4, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the zk-reorg branch September 4, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

Assignees

@zktony zktony

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zktony @Gauthamastro @serhii-temchenko