Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trading Fees, LMP and much more #884

Merged
merged 183 commits into from
Mar 6, 2024
Merged

Trading Fees, LMP and much more #884

merged 183 commits into from
Mar 6, 2024

Conversation

Gauthamastro
Copy link
Member

@Gauthamastro Gauthamastro commented Dec 1, 2023

Issue ticket number and link

Closes https://github.com/Polkadex-Substrate/issue-tracker/issues/261

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@Gauthamastro Gauthamastro self-assigned this Dec 1, 2023
@Gauthamastro Gauthamastro added the A3-InProgress Pull request is in progress. No review needed at this stage. label Dec 1, 2023
# Conflicts:
#	pallets/thea-executor/src/lib.rs
@Gauthamastro
Copy link
Member Author

@serhii-temchenko Liquidity mining is enabled in this release. It will be a seperate release. You can ignore that for now.

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Mar 5, 2024
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Mar 6, 2024
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 44.90791% with 1017 lines in your changes are missing coverage. Please review.

Project coverage is 41.38%. Comparing base (ee7c18c) to head (039df27).
Report is 1 commits behind head on Develop.

❗ Current head 039df27 differs from pull request most recent head aabb855. Consider uploading reports for the commit aabb855 to get more accurate results

Files Patch % Lines
pallets/ocex/src/lib.rs 61.17% 238 Missing ⚠️
pallets/ocex/src/validator.rs 25.87% 212 Missing ⚠️
pallets/liquidity-mining/src/lib.rs 51.63% 148 Missing ⚠️
pallets/ocex/src/lmp.rs 47.91% 100 Missing ⚠️
pallets/ocex/rpc/src/lib.rs 0.00% 72 Missing ⚠️
pallets/ocex/src/weights.rs 0.00% 61 Missing ⚠️
pallets/liquidity-mining/src/callback.rs 50.56% 44 Missing ⚠️
primitives/orderbook/src/types.rs 15.15% 28 Missing ⚠️
pallets/ocex/src/benchmarking.rs 0.00% 18 Missing ⚠️
pallets/thea-executor/src/weights.rs 0.00% 16 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #884      +/-   ##
===========================================
+ Coverage    39.39%   41.38%   +1.99%     
===========================================
  Files           63       67       +4     
  Lines         4094     5412    +1318     
===========================================
+ Hits          1613     2240     +627     
- Misses        2481     3172     +691     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Mar 6, 2024
@Gauthamastro Gauthamastro merged commit b569ae9 into Develop Mar 6, 2024
2 checks passed
@Gauthamastro Gauthamastro deleted the gj/lmp branch March 6, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants