-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainnet Runtime version: 358 #961
Conversation
…r/integrate-simulator # Conflicts: # Cargo.lock # Cargo.toml # nodes/mainnet/src/chain_spec.rs # xcm-simulator/Cargo.toml # xcm-simulator/src/lib.rs # xcm-simulator/src/parachain.rs
## Describe your changes Added log to find about index overflow.
## Describe your changes 1. Registers main account and deposits the assets on detection of direct deposit XCM type 2. Modified Ob Withdrawal to use Multilocation for direct withdrawal from OB. ## Issue ticket number and link #956 ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] I removed all Clippy and Formatting Warnings. - [ ] I added required Copyrights.
## Describe your changes The current set comparison is not working as expected. It is generating `ValidatorSetRotated` events before `ScheduleRotateValidators`, breaking the Thea session change. ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] I removed all Clippy and Formatting Warnings. - [ ] I added required Copyrights.
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainnet-release #961 +/- ##
===================================================
- Coverage 40.86% 40.44% -0.43%
===================================================
Files 67 72 +5
Lines 5648 5786 +138
===================================================
+ Hits 2308 2340 +32
- Misses 3340 3446 +106 ☔ View full report in Codecov by Sentry. |
Describe your changes
Checklist before requesting a review