Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--v appearing #17

Open
Asamartino opened this issue Nov 7, 2023 · 1 comment · May be fixed by #25
Open

--v appearing #17

Asamartino opened this issue Nov 7, 2023 · 1 comment · May be fixed by #25

Comments

@Asamartino
Copy link
Collaborator

Is there an easy fix to solve this --v appearing (see below)?

image

@nuke-web3
Copy link
Contributor

This is due to a conflict with prettier and dprint formatters, with the default vertical side separator for reveal of 4 - chars. Plain markdown doesn't render \n---v\n as a <hr/> and not sure it's worth it to add some workaround to get some mdbook preprocessr to fix it.

Both formatters correct \n----\n to \n---\n , so vertical slides are clobbered if you change them. We want vertical slides, so need a workaround...

One hack could be simply wrapping/prefixing every vertical slide separator in a for matter ignore block and move back to the default separator, like:

<!-- prettier-ignore -->
----

This is easy to do in bulk with a global find&replace, but hard to enforce in writing slide and to lint for. So not ideal, and I would bet lead to at least some amont of frustration and manual review to ensure the formatter doesn't fight the content creators here.

nuke-web3 added a commit that referenced this issue Nov 20, 2023
@nuke-web3 nuke-web3 linked a pull request Nov 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants