-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[666] Icons not vertical-aligned correctly #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 1ce664c.
WellingtonMatheus
approved these changes
Oct 14, 2022
soujvnunes
changed the title
Icons not vertical-aligned correctly
[666] Icons not vertical-aligned correctly
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons not vertical-aligned correctly
After the redesign of some icons, primarily prottoyped for Home V2, these are being:
During the implementation, was encountered some issues between Storybook and React JS Scripts. Those are being covered in the app README.
References
π‘ Functionality
Test
Please, follow along the success of the implementation by style class and a11y attributes.
yarn test
;Storybook
See how the
Icon
behave on screen through Storybook example story.yarn storybook
β‘ Changelog
.storybook/
<Icon />
</ModalSection />
components/index.ts
<Icon />
styles/theme/_tokens.scss
.eslintignore
.eslintrc.json
README.md
package.json
π Backlog
src/assets/icons
<Icon />
Footnotes