Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[666] Icons not vertical-aligned correctly #158

Merged
merged 29 commits into from
Oct 24, 2022
Merged

[666] Icons not vertical-aligned correctly #158

merged 29 commits into from
Oct 24, 2022

Conversation

soujvnunes
Copy link
Contributor

@soujvnunes soujvnunes commented Oct 3, 2022

Icons not vertical-aligned correctly

After the redesign of some icons, primarily prottoyped for Home V2, these are being:

  • implemented and served with a11y and optical fixture resources;
  • presented throught Storybook;
  • and tested;

During the implementation, was encountered some issues between Storybook and React JS Scripts. Those are being covered in the app README.

References

  1. Browse Stories;
  2. babel-loader devDependency causes error in Create-React-App

πŸ’‘ Functionality

Test

Please, follow along the success of the implementation by style class and a11y attributes.

  1. yarn test;

Storybook

See how the Icon behave on screen through Storybook example story.

  1. yarn storybook

⚑ Changelog

Unit 🟒 Added 🟑 Changed πŸ”΄ Removed
🟒 .storybook/ Adds preflight config for Storybook
🟒 <Icon /> Adds icons unity to handle the redesigned and customized a11y and fixture prop graphics
Adds styles to handle default fixture ones, size and direction responsivity
Adds story to present an Example of usage
Tests fixture, size and direction responsivity
Adds a set of svg files which references its graphic icons as React Components
🟑 </ModalSection /> Uses css var for its bottom margin
🟑 components/index.ts Indexes <Icon />
🟑 styles/theme/_tokens.scss Adds CSS varis for sizing tokens
🟑 .eslintignore Adds storybook's dir to be ignored
🟑 .eslintrc.json Adds storybook's plugins extensions
🟑 README.md Adds storybook's troubleshooting
🟑 package.json Adds storybook's dev/deps and configs

πŸ› Backlog

Unit Has story? Description
src/assets/icons πŸ”΄ Needs to be reviwed, since icons is being implemented through the <Icon />

Footnotes

useHook() is related to React JS hooks, located on src/hooks/ path;

<Component />/ <Component [prop=value] /> is related to React JS components, located on src/components/ path;

module() is related to modules located on src/utils/ or anywhere else on the app that provides some usefull shared resource;

@soujvnunes soujvnunes changed the title Feat/666 Icons not vertical-aligned correctly Oct 3, 2022
@soujvnunes

This comment was marked as outdated.

@soujvnunes soujvnunes marked this pull request as ready for review October 14, 2022 15:42
@soujvnunes soujvnunes changed the title Icons not vertical-aligned correctly [666] Icons not vertical-aligned correctly Oct 17, 2022
@rsmarques rsmarques merged commit 29237ab into main Oct 24, 2022
@rsmarques rsmarques deleted the feat/666 branch October 24, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants