Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to arrow functions and remove .bind() #719

Open
wants to merge 4 commits into
base: frontend
Choose a base branch
from

Conversation

Libens-bufo
Copy link

@Libens-bufo Libens-bufo commented Sep 1, 2022

Description of change(s), including why:

Converted arrow functions in various frontend pages to arrow functions which do not have their own 'this'. Therefore, the arrow functions will point to the 'this' of their lexical scope, in this case the component. So the .bind functions become unneeded, and were removed. Some callbacks in render functions containing .bind method to pass in arguments were changed to arrow functions returning the needed function with args.

Type of change(s)

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Any work to still do or other concerns:

N/A

Closing issues:

Screenshots (if frontend change) of before and after:

There are no visual changes to the frontend.

@Libens-bufo
Copy link
Author

@hbh7

@hbh7 hbh7 self-requested a review September 4, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant