Fix RequestCollapserEngine caching lazy with exceptions as value indefinitely #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill result in the RequestCollapser's Engine to cache the exception indefinitely.
veleek
reviewed
Jun 4, 2020
src/Polly.Contrib.DuplicateRequestCollapser.Specs/RequestCollapserTResultSpecsBase.cs
Outdated
Show resolved
Hide resolved
veleek
reviewed
Jun 4, 2020
src/Polly.Contrib.DuplicateRequestCollapser.Specs/RequestCollapserTResultSpecsBase.cs
Outdated
Show resolved
Hide resolved
veleek
reviewed
Jun 4, 2020
src/Polly.Contrib.DuplicateRequestCollapser.Specs/RequestCollapserTResultSpecsBase.cs
Outdated
Show resolved
Hide resolved
veleek
reviewed
Jun 4, 2020
src/Polly.Contrib.DuplicateRequestCollapser.Specs/RequestCollapserTResultSpecsBase.cs
Outdated
Show resolved
Hide resolved
veleek
reviewed
Jun 4, 2020
src/Polly.Contrib.DuplicateRequestCollapser.Specs/RequestCollapserTResultSpecs.cs
Show resolved
Hide resolved
|
@reisenberger Would love your input |
|
How do we get an updated nuget built? |
|
@veleek @reisenberger Either of you able to do the nuget voodoo for this? I think v. 0.3.0 would be the next version. |
|
I do not. I'm assuming everybody in the https://github.com/orgs/Polly-Contrib/people group have access. |
|
@jjxtra I'll help you out with the package deployment. Taking a look now. |
|
@joelhulen Thank you so much for your assistance! |
|
Of course! Thank you for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the valueFactory inside a Lazy object throws an exception, the collapser engine is not properly cleaning it up from the ConcurrentDictionary. This results in the RequestCollapserPolicy caching the result indefinitely.