Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crash on mod search #33

Closed
lillyschulte opened this issue Jul 31, 2023 · 2 comments
Closed

[BUG] Crash on mod search #33

lillyschulte opened this issue Jul 31, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lillyschulte
Copy link

Describe the bug
When searching for mods by using the [Y} Search funtion the software crashes with the error message:
"The software was closed because an error accurred"
This occurred to me when searching for mods for Mario kart 8 deluxe.

On which mod
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Go to Simple mod downloader
  2. Click on Mario kart 8 Deluxe
  3. Click on [Y] Seach
  4. Enter seach query
  5. Press Search
  6. See error

Expected behavior
Show search results based on search query

Screenshots
If applicable, add screenshots to help explain your problem.

Switch:

  • Atmosphere version 1.5.4E
  • Hekate 6.0.5
  • Firmware 16.0.3
  • Mario Kart version 2.4.0
  • SimpleModDownloader version 1.0.3

Additional context
This somehow doesnt occure when searching for "Shrek".
This made me think that it maybe had something to do with the software not being able to handle when there are no results on gamebanana. Tested this out by searching for a mods keywords, that i know exists on gamebanana(Example used:https://gamebanana.com/mods/172093. Keyword used: Miata& Miata ND). Yet the software still crashes.

@lillyschulte lillyschulte added the bug Something isn't working label Jul 31, 2023
@PoloNX
Copy link
Owner

PoloNX commented Aug 1, 2023

Thanks for the report. I will investigate in the day

PoloNX added a commit that referenced this issue Aug 1, 2023
@PoloNX
Copy link
Owner

PoloNX commented Aug 1, 2023

It's a stupid bug added here : e7714e9

Fixed in the latest commit

@PoloNX PoloNX closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants