Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to force tv region based on detected ROM #71

Merged
merged 8 commits into from
Dec 17, 2023
Merged

Add ability to force tv region based on detected ROM #71

merged 8 commits into from
Dec 17, 2023

Conversation

networkfusion
Copy link
Collaborator

Description

Add ability to force tv region based on detected ROM based on the ROM's destination code.
Adds a setting so that this can be turned off (on by default).

Motivation and Context

#66

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@networkfusion
Add auto detect region settings
208a3ba 
Add comments for how to implement.
@networkfusion
Add detection check
550228e 
(still needs to take into account the setting).
@networkfusion
Use region detection based on setting
8c140b4
@networkfusion
Improve setting name
244bdfb 
Mark as production worthy.
@networkfusion networkfusion added the enhancement New feature or request label Dec 17, 2023
@networkfusion networkfusion added this to the v1.0 milestone Dec 17, 2023
@networkfusion
Copy link
Collaborator Author

@Polprzewodnikowy If you can think of better names for settings and functions, please let me know.

@Polprzewodnikowy Polprzewodnikowy merged commit 3e13e88 into Polprzewodnikowy:main Dec 17, 2023
2 checks passed
@networkfusion networkfusion deleted the force-tv-region branch December 17, 2023 16:52
@Polprzewodnikowy Polprzewodnikowy mentioned this pull request Dec 17, 2023
Closed
@TharathielCB TharathielCB mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polprzewodnikowy Polprzewodnikowy Polprzewodnikowy left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@networkfusion @Polprzewodnikowy