Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFIO 2.1 #2

Merged
merged 17 commits into from
Jun 7, 2021
Merged

BFIO 2.1 #2

merged 17 commits into from
Jun 7, 2021

Conversation

Nicholas-Schaub
Copy link
Contributor

@Nicholas-Schaub Nicholas-Schaub commented May 6, 2021

This PR adds a number of useful features and functions. To summarize the major changes:

  1. Changed from Javabridge to JPype
  2. Java no longer needs to be manually started. bfio now handles Java behind the scenes.
  3. OME Zarr is now semi-supported. The pixel data is properly laid out in the file according to the OME Zarr spec, but all aspects of the spec have not been implemented. For example, all images are saved using the multiscales spec, but multiple images within a single file or the HCS spec are not supported.
  4. New deflate compression. Originally implemented by directly binding libdeflate, but recently tifffile incorporated it into their package, so the minimum tifffile version was bumped.
  5. Can now install optional dependencies using all, jpype, and zarr. For example, pip install bfio['all'].
  6. Updated documentation.

Things that still need to be done:

Add documentation on containerization.
Add more examples showing additional functionality, such as using the zarr backend or the readerator/writerator.
Add git actions for the master and dev branches to autobuild and push packages to PyPi.

@hsidky
Copy link

hsidky commented Jun 1, 2021

Looks good. There seems to be a minor regression in bfio.py. Otherwise it looks good to go.

I should note that I say this in light of the next PR that you've opened.

@Nicholas-Schaub Nicholas-Schaub merged commit c8c975d into main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants