Zarr support with tensorstore backend #83
Conversation
| return str(root_path.resolve()), axes_list | ||
| elif isinstance(root, zarr.hierarchy.Group): | ||
| # the top level is a group, check if this has any arrays | ||
| num_arrays = len(sorted(root.array_keys())) |
There was a problem hiding this comment.
Why is this the len of the sorted function instead of just taking the length of root.array_keys()?
There was a problem hiding this comment.
array_keys() is actually a generator function. Calling sorted on it actually generate the list and then we can get the length of all the elements produced by the generator.
Since the list contains small number of elements (~20 max), I don't expect this to be a huge overhead. I wish there is any other trick to do that.
| root = zarr.open(str(root_path.resolve()), mode="r") | ||
| except zarr.errors.PathNotFoundError: | ||
| # a workaround for pre-compute slide output directory structure | ||
| root_path = self.frontend._file_path / "data.zarr" |
There was a problem hiding this comment.
Should this log a warning or is it expected behavior?
There was a problem hiding this comment.
This is expected behavior. Pyramid zarr outputs from precompute slide plugin puts everything inside this data.zarr and then puts this directory in a top level directory. This is something how Viv wants the folder to be organized.
| self.logger.debug("__init__(): Initializing _rdr (TSTiffReader)...") | ||
| self._rdr = TSTiffReader(str(self.frontend._file_path)) | ||
| self.logger.debug("__init__(): Initializing _rdr (TSReader)...") | ||
| extension = "".join(self.frontend._file_path.suffixes) |
There was a problem hiding this comment.
Is it possible to access frontend._file_path through a public method or is this the only way?
There was a problem hiding this comment.
There are no getters for this object at the moment. Since everything is public in Python and this is a low-level library implementation code (no user API has direct access to frontend), I opted not to add another layer of indirection.
No description provided.