Fix bug, fix more warnings (See commit description) #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LennyMcLennington
requested changes
May 9, 2023
Comment on lines
302
to
309
| } | ||
| default: { | ||
| // FIXME: See if MultiSelection / ExtendedSelection need to be handled | ||
| if (selectionType != QAbstractItemView::NoSelection) | ||
| qWarning() << "Unhandled QAbstractItemView selection type!"; | ||
| break; | ||
| } |
There was a problem hiding this comment.
What do you think about just breaking on ones that we know we should ignore instead of using an if statement to exclude them from the default case?
Suggested change
| } | |
| default: { | |
| // FIXME: See if MultiSelection / ExtendedSelection need to be handled | |
| if (selectionType != QAbstractItemView::NoSelection) | |
| qWarning() << "Unhandled QAbstractItemView selection type!"; | |
| break; | |
| } | |
| } | |
| case QAbstractItemView::NoSelection: | |
| break; | |
| default: { | |
| // FIXME: See if MultiSelection / ExtendedSelection need to be handled | |
| qWarning() << "Unhandled QAbstractItemView selection type:" << selectionType; | |
| break; | |
| } |
launcher/ui/WinDarkmode.cpp
Outdated
Comment on lines
78
to
89
| if (IsWindows8_0_Only()) | ||
| WinSyscall<NtUserSetWindowCompositionAttribute_NT6_2>(hWnd, &data); | ||
| if (IsWindows8_1_Only()) | ||
| WinSyscall<NtUserSetWindowCompositionAttribute_NT6_3>(hWnd, &data); | ||
| if (IsWindows10_Only() || IsWindows11()) | ||
| { | ||
| ((fnSetWindowCompositionAttribute)(PVOID)GetProcAddress(GetModuleHandleW(L"user32.dll"), "SetWindowCompositionAttribute")) | ||
| (hWnd, &data); | ||
| // Verified this ordinal is the same through Win11 22H2 (5/8/2023) | ||
| ((fnSetPreferredAppMode)(PVOID)GetProcAddress(GetModuleHandleW(L"uxtheme.dll"), MAKEINTRESOURCEA(135))) | ||
| (AppMode_AllowDark); | ||
| } |
There was a problem hiding this comment.
If these are mutually exclusive wouldn't it make more sense to use else if instead of if for the subsequent checks
This ends my series of patches fixing warnings throughout the codebase. Now, there are NO warnings except for unused parameters, tested on GCC 13.1.1 and Clang 16.0.2 with -Wall -Wextra. Fixed dark mode crashing on Windows 8.1, 8 and 7, and removed a need for an export by moving in the function. Any people looking at the Windows code and asking why I didn't use official version querying API's, those typically have some sort of unwanted behavior, plus checking exports to determine versions is shorter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends my series of patches fixing warnings throughout the codebase. Now, there are NO warnings except for unused parameters, tested on GCC 13.1.1 and Clang 16.0.2 with -Wall -Wextra.
Fixed dark mode crashing on Windows 8.1, 8 and 7, and removed a need for an export by moving in the function.
Any people looking at the Windows code and asking why I didn't use official version querying API's, those typically have some sort of unwanted funny behavior (compatibility manifests, other ought-to-be nonsense), plus checking exports to determine versions is shorter.