Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLauncher: Handle depends for main class and extra arguments #630

Merged
merged 3 commits into from May 25, 2022

Conversation

jamierocks
Copy link
Contributor

@jamierocks jamierocks commented May 23, 2022

Closes #485

This fixes a bug with installing All The Forge 8 where the main class would erronously be set to LaunchWrapper.

This was a result of not handling depends on mainClass (see below for an example). Where the mod depended on was no longer present (mod loaders have much better support on ATLauncher now).

    "mainClass": {
        "mainClass": "net.minecraft.launchwrapper.Launch",
        "depends": "Minecraft Forge"
    },

The commit(s) contained within this pull request have been cherry-picked from my own private fork of MultiMC from circa September 2021.

For the benefit of PolyMC: My fork is prior to multiple licences covering the MultiMC codebase, and no longer pulls changes from MultiMC as a result of these developments.

For the benefit of PolyMC and MultiMC: I only do development on a PolyMC or MultiMC workspace to resolve merge-conflicts, and to get changes building. No commits are ever cherry-picked onto my fork from a PolyMC or MultiMC workspace - nor between the two in either direction.

Copy link
Contributor

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Scrumplex
Copy link
Contributor

We had someone with this problem once. I assumed it was a bug with the pack, but apparently it wasnt :D

@jamierocks
Copy link
Contributor Author

I've added an additional patch to fix installing SevTech: Ages :)

Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Scrumplex Scrumplex merged commit 7f73e57 into PolyMC:develop May 25, 2022
@Scrumplex Scrumplex modified the milestones: 1.4.0, 1.3.1 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to find Minecraft main class
4 participants