ATLauncher: Handle depends for main class and extra arguments #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485
This fixes a bug with installing All The Forge 8 where the main class would erronously be set to LaunchWrapper.
This was a result of not handling
depends
onmainClass
(see below for an example). Where the mod depended on was no longer present (mod loaders have much better support on ATLauncher now).The commit(s) contained within this pull request have been cherry-picked from my own private fork of MultiMC from circa September 2021.
For the benefit of PolyMC: My fork is prior to multiple licences covering the MultiMC codebase, and no longer pulls changes from MultiMC as a result of these developments.
For the benefit of PolyMC and MultiMC: I only do development on a PolyMC or MultiMC workspace to resolve merge-conflicts, and to get changes building. No commits are ever cherry-picked onto my fork from a PolyMC or MultiMC workspace - nor between the two in either direction.