Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame addRow does not consider key order #106

Open
AtharvaKhare opened this issue Jun 21, 2019 · 0 comments
Open

DataFrame addRow does not consider key order #106

AtharvaKhare opened this issue Jun 21, 2019 · 0 comments

Comments

@AtharvaKhare
Copy link
Contributor

@AtharvaKhare AtharvaKhare commented Jun 21, 2019

df := DataFrame
	withRows: #(
		('A1' 'B1' 'D1' 'C1')
		('A2' 'B2' 'D2' 'C2'))
	columnNames: #('A' 'B' 'D' 'C').
	
ds := DataSeries
	withKeys: #('A' 'B' 'C' 'D')
	values: #('A3' 'B3' 'C3' 'D3')
	name: 3.
	
df addRow: ds.

Inspecting df gives us:
wrong_dataframe

Rotating ds's keys does not affect output

ds := DataSeries
	withKeys: #('D' 'C' 'B' 'A')
	values: #('D3' 'C3' 'B3' 'A3')
	name: 3.
	
df addRow: ds.

wrong_dataframe

DataFrame addRow: should rearrange ds's keys values according to keys before adding them into the DataFrameInternal

@olekscode olekscode added this to To do in DataFrame Jul 26, 2021
@olekscode olekscode added this to the v3.0 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants