Allow booleans to be any case. #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other programs output their boolean values as uppercase (Excel, R) or sentence case (python). This change makes DataFrameTypeDetector>>canAllBeBoolean less stringent so that any case is accepted.
Added in a couple of extra tests to make sure that a data series of numbers or of other strings doesn't get detected as a boolean column
github-actions bot
pushed a commit
to mabdi/DataFrame
that referenced
this pull request
Mar 24, 2022
…L20_L182 SmallAmp has derived this test from `DataFrameInternalTest>>#testWithRows` by applying some transformations and regenerating its assertions. This test can cover this part: * In `DataFrameInternal class>> #withRows:` from 134 to 134: Operation: LiteralIntegersIncreaseOperator Code snippet: `0` Dynamic state: nil Mutant id: LiteralIntegersIncreaseOperator#DataFrameInternal class#withRows:PolyMathOrg#134#134
github-actions bot
pushed a commit
to mabdi/DataFrame
that referenced
this pull request
Mar 24, 2022
SmallAmp has derived this test from `DataFrameInternalTest>>#testRowsAt` by applying some transformations and regenerating its assertions. This test can cover this part: * In `DataFrameInternal class>> #withRows:` from 134 to 134: Operation: LiteralIntegersIncreaseOperator Code snippet: `0` Dynamic state: nil Mutant id: LiteralIntegersIncreaseOperator#DataFrameInternal class#withRows:PolyMathOrg#134#134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other programs output their boolean values in CSV files as uppercase (Excel, R) or sentence case (python). This change makes
DataFrameTypeDetector>>canAllBeBooleanless stringent so that any case is accepted.