Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor polynomials #323

Merged
merged 42 commits into from
Jan 3, 2024
Merged

Refactor polynomials #323

merged 42 commits into from
Jan 3, 2024

Conversation

hemalvarambhia
Copy link
Contributor

@hemalvarambhia hemalvarambhia commented Dec 27, 2023 •
edited

  • Improved naming;
  • Tightened Encapsulation;
  • Added some missing tests, including demonstrating that multiplication is commutative.
  • Made tests more like examples written with DSLs

@hemalvarambhia
refactor: Extract a method which encapsulates how to calculate the ro…
cf05114 
…ot of a function.
@hemalvarambhia
refactor: Rename Variable, where we clarified the name by using the f…
8ebadd3 
…ull form.
@hemalvarambhia
refactor: use strictlyPositive to hide the type of Number being refer…
5146d59 
…red to.
@hemalvarambhia
refactor: clarified the name of a category.
c114607
@hemalvarambhia
refactor - recategorised the multiplication tests in preparation for …
645b5f5 
…more tests.
@hemalvarambhia
test: wrote a test to demonstrate that multiplication is commutative.
43d01c7
@hemalvarambhia
refactor: made the test a little more generic.
ca6a896
@hemalvarambhia
test: made the example a little more complicated (example derived fro…
4ddb4ef 
…m Wolfram Alpha).
@hemalvarambhia
format: followed arrange, act and assert.
8089cc2
@hemalvarambhia
refactor: recategorised some tests for addition.
9fd2c1f
@hemalvarambhia
refactor: recategorised more tests for the other binary operations.
4d7ce1a
@hemalvarambhia
refactor: replaced multiple assertions with use of assert: equals: wh…
4a23af2 
…ich uses the object's = message.
@hemalvarambhia
refactor: Rename Variable, where we give objects names similar to tho…
f818335 
…se used in mathematics.
@hemalvarambhia
refactor: we equate a product with its expected result directly.
2bfcd0e
@hemalvarambhia
refactor: Rename Variable with domain language.
e0c2919
@hemalvarambhia
refactor: used the assert: equals message rather than check each coef…
05ba156 
…ficient.
@hemalvarambhia
refactor: Rename Variable so it reflects the role played by the object.
4b7f888
@hernanmd
Copy link
Contributor

There is only 1 test failing testOptimize on linux

@hemalvarambhia
Copy link
Contributor Author

There is only 1 test failing testOptimize on linux

Restarted the CI run.

@hemalvarambhia
refactor: extracted temp, renamed a temp to tell a better story.
c76f8f9
@hemalvarambhia
test: added a comment describing the example the way a mathematician …
6f02880 
…would understand it.
@hemalvarambhia
refactor: replaced equating constants with equating polynomials.
26f762c
@hemalvarambhia
refactor: replaced equating coefficients with equating the polynomial.
1d08970
@hemalvarambhia
refactor: extract temp so we can show the computation being tested cl…
84b6af9 
…early.
@hemalvarambhia
refactor: replaced equating coefficients with equating Polynomials.
aaefdcf
@hemalvarambhia
test: Extract Variable, so that the operation being tested clear.
4ddc12b
@hemalvarambhia
refactor: Extract Variable so we can show the operation being tested …
75c2fd8 
…clearly.
@hemalvarambhia
refactor: Extract Variable so we can demonstrate the operation being …
d4fed03 
…tested clearly.
@hemalvarambhia
refactor: replaced assertions on coefficients with a Polynomial.
2ba7c68
@hemalvarambhia
refactor: Extract variable so we can make the operation being tested …
8320ec0 
…clearer.
@hemalvarambhia
refactor: extracted the expected coefficients to a local variable to …
4b89858 
…make equating Polynomials simpler.
@hemalvarambhia
refactor: extracted magic number and integrand to local variables.
63b3779
@hemalvarambhia
refactor: Rename Variable: the polynomial is the integrand.
a3e7f96
@hemalvarambhia
refactor: reduce the number of assertions by equating polynomials rat…
ecb00fc 
…her than coefficients.
@hemalvarambhia
documentation: added documentation to demonstrate how a mathematician…
a286790 
… would integrate a polynomial w.r.t. x.
@hemalvarambhia
fix: corrected the documentation.
efb2a87
@hemalvarambhia
fix: added a missing assertion.
eb0a97f
@hemalvarambhia
refactor: we can use the arbitrary constant in our expected coefficie…
85c2398 
…nts of the integrated polynomial.
@hernanmd hernanmd merged commit 11c8e01 into master Jan 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hernanmd hernanmd hernanmd approved these changes

@SergeStinckwich SergeStinckwich Awaiting requested review from SergeStinckwich

@Ducasse Ducasse Awaiting requested review from Ducasse

@olekscode olekscode Awaiting requested review from olekscode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hemalvarambhia @hernanmd