reduce BREAK_PEDAL_OVERRIDE_THRESHOLD #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Aug 22, 2018
ghost
added
ghost
requested a review
from 
cotos
reviewed
Sep 19, 2018
api/include/vehicles/kia_niro.h
Outdated
| @@ -242,7 +242,7 @@ typedef struct | |||
| * @brief Value of the accelerator position that indicates operator override. [steps] | |||
There was a problem hiding this comment.
The comment should say Value of the brake position
cotos
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAK_PEDAL_OVERRIDE_THRESHOLD in https://github.com/PolySync/oscc/blob/master/api/include/vehicles/kia_niro.h was originally =200. It is now reduced to 130 which is the observed level at which the brake lights are triggered.
Initial testing on vehicle shows this threshold is high enough to not trigger accidental overrides when braking with joystick commander.
closes issue DriveKit/#117