New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong calculating of chunk size #78
Conversation
Hello @mastak, I think this should probably be done in the encoder, to abstract the type from parent code ? |
Hello @dzen, To tell the truth, I do not quite understand what you mean...) Some thing like that?
According to the source code, |
I thing you get the whole picture: we have to delegate the request to another class. This class should handle how we build a request for a chunk'd payload and deal with payload's encoding What if we get a encoder_frame = PayloadEncoder()
encoder_frame.write_payload(payload, chunk_size=self.protocol.server_frame_max)
self.protocol.writer(encoder_frame.to_request_frame()) |
Ok, I will try to make it ;) |
Bump? |
So the fix looks good, but I'm just tempted to throw out the Would anyone object to the change? It would simply move the Cheers |
Is this still the case since we just moved to pamqp ? |
I process the text data from external service, and sometimes it can contain some data like:
So after encode this string is increasing.