Refactor waiter handling in channel #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you using the no_wait argument with aioamqp ? |
|
beware of the typo |
|
I am not using no_wait, it was just the visual noise in the code (and the open issue) prompting a friday afternoon tidy. |
foolswood
changed the title
|
Happy to know we have a few tests ;) |
foolswood
force-pushed
the
waiter_refactor
branch
from
8d85769
to
1706350
Compare
|
I was leaning on them for this, they did their job, let's see if that fix makes things any better. |
|
Seems fine now, fixed the typo whilst at it. |
| @@ -188,21 +188,32 @@ def server_channel_close(self, frame): | |||
| self.connection_closed(results['reply_code'], results['reply_text']) | |||
|
|
|||
| @asyncio.coroutine | |||
| def _write_frame_awaiting_response( | |||
| self, waiter_id, frame, request, no_wait, **kwargs): | |||
There was a problem hiding this comment.
This indentation seems really odd. Since there are lines with lenght longer than 80, we should keep this code style
|
I believe this is ready now. |
|
Yes, squash both commits and I'll merge it |
foolswood
force-pushed
the
waiter_refactor
branch
from
06f6add
to
ac3dc1f
Compare
|
They're squashed. |
|
It's merged since yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough pass at tidying up waiter handling.