Add support for compiling strings from JavaScript expressions in filters #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers. For example, presented with the fragment `<span ng-bind="isNight ? 'Moon' + 'shine' : 'Day' + 'light' |translate"></span>` the extractor will produce both `Moonshine` and `Daylight`. Additionally, efforts have been made to make sure escaped quotes in the source are handled correctly, so that the whole round-trip from extracting translatable strings from the source through translating them into .po files and looking them up during runtime works as expected, with strings like `'Five o\'clock'`.
|
I'll do as I've been encouraged to, and merge this pull request myself. 😄 Can you please provide a new NPM build @vperron? |
|
Hi! Is there any chance you'll be able to publish a new NPM version today, @vperron? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, presented with the fragment
<span ng-bind="isNight ? 'Moon' + 'shine' : 'Day' + 'light' |translate"></span>the extractor will produce both
MoonshineandDaylight.Additionally, efforts have been made to make sure escaped quotes in the source
are handled correctly, so that the whole round-trip from extracting translatable strings
from the source through translating them into .po files and looking them up during
runtime works as expected, with strings like
'Five o\'clock'.