-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug/Proposition] Normalize pipeline sampler coordinates to match world coordinates #264
Labels
Platform: All
Issue/PR is applicable to all platforms.
Status: Accepted
Issue/PR is accepted.
Subsystem: Biome Pipeline
Issue/PR has to do with the biome pipeline in Terra.
Subsystem: Generation
Issue/PR has to do with all other generation subsystems.
Comments
Astrashh
added
Status: Pending
Issue/PR is currently awaiting approval by a moderator.
Type: Bug
Something isn't working as intended.
labels
Sep 1, 2021
Astrashh
added
Platform: All
Issue/PR is applicable to all platforms.
Subsystem: Biome Pipeline
Issue/PR has to do with the biome pipeline in Terra.
Subsystem: Generation
Issue/PR has to do with all other generation subsystems.
Status: Pending
Issue/PR is currently awaiting approval by a moderator.
and removed
Type: Bug
Something isn't working as intended.
Status: Pending
Issue/PR is currently awaiting approval by a moderator.
labels
Sep 9, 2021
dfsek
added
Note: Good First Issue
Good for anyone looking to learn the internals of Terra
Status: Accepted
Issue/PR is accepted.
and removed
Status: Pending
Issue/PR is currently awaiting approval by a moderator.
labels
Sep 19, 2021
This comment was marked as spam.
This comment was marked as spam.
Astrashh
changed the title
[Bug/Proposition] Biome provider resolution should not affect biome scale
[Bug/Proposition] Normalize pipeline sampler coordinates to match world coordinates
Jul 10, 2022
Expanding on this, expander stages shouldn't affect sampler input coordinates either Making this change will allow for other sampler usages to match biome distribution, allowing for things like adjusting terrain height based on proximity to oceans and or rivers |
duplexsystem
added a commit
to duplexsystem/Terra
that referenced
this issue
Jul 15, 2022
Astrashh
added a commit
to PolyhedralDev/TerraOverworldConfig
that referenced
this issue
Jul 23, 2022
This isn't enabled by default, relies upon PolyhedralDev/Terra#264 to be fixed. Terrain heightmaps should simply be multiplied by the riverTerrainMask sampler to factor in rivers.
Test pack for this issue: Grids should line up if this issue is fixed |
Astrashh
removed
the
Note: Good First Issue
Good for anyone looking to learn the internals of Terra
label
Aug 2, 2022
Fixed with #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Platform: All
Issue/PR is applicable to all platforms.
Status: Accepted
Issue/PR is accepted.
Subsystem: Biome Pipeline
Issue/PR has to do with the biome pipeline in Terra.
Subsystem: Generation
Issue/PR has to do with all other generation subsystems.
Currently, the value of
pack:biomes.resolution
increases the final scale of the output of the biome provider. I believe that this shouldn't be the case, as the options main use case is for tuning performance (sacrificing fidelity to reduce biome calculations per unit of space), and shouldn't have an impact on increasing the scale of biomes.The advantage of removing
pack:biomes.resolution
's modification of scale is that you will be able to tune performance (via the reduced fidelity that comes with increasing the resolution) independently from other more suitable methods of scaling biome distribution.For config developers who wish to maintain a 'baseline scale' any time resolution is changed, this would remove the process of reconfiguring the biome provider scale options. In addition, this would remove an additional factor that goes into biome scale, reducing unneeded complexity from the process of both understanding, and tuning biome scale.
The text was updated successfully, but these errors were encountered: