moar biome settings 2: electric boogaloo #330
Conversation
duplexsystem
force-pushed
the
dev/enviroment
branch
from
18d79a9
to
18de2c3
Compare
duplexsystem
force-pushed
the
dev/enviroment
branch
from
cddc9a7
to
7a4bf38
Compare
|
Next time can you not reformat all files, it makes reviewing very tedious. |
gradle.properties
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Magic options for more perf | |||
| org.gradle.jvmargs=-Xmx2048M -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 -XX:+UseParallelGC | |||
| org.gradle.jvmargs=-Xmx3048M -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 -XX:+UseParallelGC | |||
There was a problem hiding this comment.
3072
But is this increase even needed?
There was a problem hiding this comment.
I was getting OOM exceptions while building -- it's up to you on whether to include this but I will need to go back and change it locally every time
| throw new IllegalStateException("Could not load all Terra classes", e); | ||
| } | ||
| } else { | ||
| // Forgive me for what I'm about to do... |
There was a problem hiding this comment.
This should not be in production code at all. Either put it in a completely separate source set, or remove it.
There was a problem hiding this comment.
I don't see why it's an issue. As we've agreed I have the burden of maintaining the forge version I can tell you that the ability to run in a dev env is a pretty necessary thing for me. The code is only run if in a dev env and even if it somehow gets run instead of the normal awful hack it will just class not found. If it's moved into a different source set it will also class not found, there is practically no change to the end user. Moving it to another source set will just clutter up the source code. And it's not like the forge impl is the peak of correctness this is literally in AwfulForgeHacks. But if your deadset on it being in a different source set I will move it
There was a problem hiding this comment.
I still dont like that its even there at all, but i guess there is no other option.
platforms/mixin-common/src/main/java/com/dfsek/terra/mod/MinecraftAddon.java
Outdated
Show resolved
Hide resolved
my bad sorry, this was just optimize imports and I didn't remove the large diff in unrelated files, I did avoid reformatting everything though. However once this is merged it would be nice if you could reformat everything as especially my new code is a little messy |
attempt 2 at pr