Victor example changes #117
Conversation
…. Add unsubscribe all
…le-changes # Conflicts: # examples/registerTicker.ts
examples/countTransferManager.ts
Outdated
| // Get some poly tokens in your account and the security token | ||
| // Poly token faucet works on test net | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000) }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Sorry, my bad. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
There was a problem hiding this comment.
Okay I tested it and saw that, I will go ahead and just remove that transfer from my files
examples/erc20Dividend.ts
Outdated
| const myAddress = await polymathAPI.getAccount(); | ||
| // Token faucet on test net only | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000), address: myAddress }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Same as above. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
| moduleName: ModuleName.erc20DividendCheckpoint, | ||
| }))[0]; | ||
|
|
||
| await polymathAPI.polyToken.transfer({ to: erc20Dividend, value: new BigNumber(5) }); |
There was a problem hiding this comment.
You don't need to transfer, with the approve from next line is ok.
examples/etherDividend.ts
Outdated
| address: await polymathAPI.securityTokenRegistry.address(), | ||
| const myAddress = await polymathAPI.getAccount(); | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000), address: myAddress }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Same as above. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
examples/generalPermissionManager.ts
Outdated
| // Get some poly tokens in your account and the security token | ||
| const myAddress = await polymathAPI.getAccount(); | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000), address: myAddress }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Same as above. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
examples/generalTransferManager.ts
Outdated
| // Get some poly tokens in your account and the security token | ||
| const myAddress = await polymathAPI.getAccount(); | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000), address: myAddress }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Same as above. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
examples/usdTieredSTO.ts
Outdated
| address: await polymathAPI.securityTokenRegistry.address(), | ||
| const myAddress = await polymathAPI.getAccount(); | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000), address: myAddress }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Same as above. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
| address: await polymathAPI.securityTokenRegistry.address(), | ||
| const myAddress = await polymathAPI.getAccount(); | ||
| await polymathAPI.getPolyTokens({ amount: new BigNumber(1000000), address: myAddress }); | ||
| await polymathAPI.polyToken.transfer({ |
There was a problem hiding this comment.
Same as above. You don't need to transfer. You only need to approve as you are doing below, then the ST calls transferFrom. So this entire line is not needed.
|
🎉 This PR is included in version 2.1.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.