This repository has been archived by the owner on Jul 6, 2022. It is now read-only.
Vesting Escrow Wallet wrapper #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basic VEW structure to interact with abi-wrapper
add calls and transactions methods to cover Vesting Escrow Wallet at 100%
add documentation for every method and interface we have
improve startTtime parameter type to handle zero value
add asserts and conversions in return types
add VEW example and fix some issues discovered in the process
monitz87
suggested changes
Aug 12, 2019
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
| interface AddTemplateParams extends TxParams { | ||
| name: string; | ||
| numberOfTokens: number; | ||
| duration: number; |
There was a problem hiding this comment.
Should be BigNumber and the comments should specify how this duration is measured (seconds, minutes, hours, etc)
There was a problem hiding this comment.
I dont understand which param should be bignumber.
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
change numberOfTokens param type from number to bignumber
monitz87
suggested changes
Aug 19, 2019
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
src/contract_wrappers/modules/wallet/vesting_escrow_wallet_wrapper.ts
Outdated
Show resolved
Hide resolved
monitz87
suggested changes
Aug 21, 2019
src/types.ts
Outdated
| @@ -61,7 +61,9 @@ import { | |||
| VolumeRestrictionTMEventArgs, | |||
| VestingEscrowWalletContract, | |||
| VestingEscrowWalletEvents, | |||
| VestingEscrowWalletUnpauseEventArgs, | |||
There was a problem hiding this comment.
Why aren't you exporting the event args?
There was a problem hiding this comment.
It was a typo mistake, I added "Unpause" but in types we should only import the generic EventArgs for each wrapper.
There was a problem hiding this comment.
What I meant was, why isn't VestingEscrowWalletEventArgs being exported?
shuffledex
changed the title
Add VEW EventArgs on types.ts and adapt the wrapper to the new ABI structure
monitz87
suggested changes
Aug 21, 2019
| ERC20DetailedContract.ABI(), | ||
| PolyTokenContract.ABI(), | ||
| PolyTokenFaucetContract.ABI(), | ||
| ISecurityTokenContract.ABI(), |
There was a problem hiding this comment.
You should add the Vesting Escrow Wallet ABI to this array
monitz87
suggested changes
Aug 21, 2019
| interface AddTemplateParams extends TxParams { | ||
| name: string; | ||
| numberOfTokens: number; | ||
| duration: number; |
| name: string; | ||
| numberOfTokens: number; | ||
| duration: number; | ||
| frequency: number; |
| * @param frequency Frequency of the created vesting schedule | ||
| * @param startTime Start time of the created vesting schedule | ||
| */ | ||
| interface AddScheduleParams extends TxParams { |
There was a problem hiding this comment.
duration and frequency should be BigNumber
| * @param frequencies Array of the vesting frequency | ||
| * @param startTimes Array of the vesting start time | ||
| */ | ||
| interface AddScheduleMultiParams extends TxParams { |
There was a problem hiding this comment.
durations and frequencies should be BigNumber[]
|
🎉 This PR is included in version 2.0.0-beta.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.