Feat/stos #119
Merged
Feat/stos #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in line with changes to the smart contracts which will allow Tiered STOs to raise funds in any denomination BREAKING CHANGE: entity `UsdTieredSto` rernamed to `TieredSto`, enum `StoType.UsdTiered` changed to `StoType.Tiered`
Also add internal support for future methods and resolver arrays
Launch functions and procedure params were named differently from the entity properties BREAKING CHANGE: rename STO entity properties for consistency
Also fixed some wrong procedure types
VictorVicente
approved these changes
Nov 20, 2019
| message: `Cannot invest on behalf of ${beneficiary} because this STO doesn't allow beneficial investments`, | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
We could add whitelist validation here in the future.
src/entities/Sto.ts
Outdated
| this.startDate = startDate; | ||
| this.endDate = endDate; | ||
| this.raisedFundsWallet = raisedFundsWallet; | ||
| this.unsoldTokensWallet = unsoldTokensWallet; | ||
| this.raisedAmount = raisedAmount; | ||
| this.soldTokensAmount = soldTokensAmount; | ||
| this.investorAmount = investorAmount; |
There was a problem hiding this comment.
Could we change this to investorCount everywhere?
Removed `investments` in favor of a `getInvestments` function. Changed `investorAmount` to `investorCount` BREAKING CHANGE: Removed `investments` in favor of a `getInvestments` function. Changed `investorAmount` to `investorCount`
VictorVicente
requested changes
Nov 26, 2019
All relevant types and enums were changed as well BREAKING CHANGE: rename CappedSto to SimpleSto
VictorVicente
approved these changes
Dec 5, 2019
|
🎉 This PR is included in version 2.0.1-beta.66 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.