Feat/percentage transfer manager #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorVicente
requested changes
Nov 26, 2019
| @@ -186,6 +201,13 @@ export class Features extends SubModule { | |||
| ); | |||
| break; | |||
| } | |||
| case Feature.ShareholderCountRestrictions: { | |||
There was a problem hiding this comment.
I guess this should be Percentage feature
| import { SubModule } from './SubModule'; | ||
| import { PolymathError } from '../../PolymathError'; | ||
| import { TransactionQueue } from '../TransactionQueue'; | ||
|
|
||
| interface WhitelistParams { |
There was a problem hiding this comment.
This should be renamed to something referring to PercentageTM. There are many modules with whitelists.
| * Retrieve whether primary issuance is allowed. If true, minting tokens can bypass percentage ownership restrictions. | ||
| * Can be modified with `modifyPercentageExemptions` | ||
| */ | ||
| public isPrimaryIssuanceAllowed = async () => { |
There was a problem hiding this comment.
Same here. We need some reference to percentage TM in the name.
Merged the percentage exemption getters into a single function.Also fixed a redundant switch case.
VictorVicente
approved these changes
Nov 26, 2019
|
🎉 This PR is included in version 2.0.1-beta.65 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.