Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added launchpad theme to ui-blocks #35

Merged
merged 5 commits into from Oct 21, 2022
Merged

feat: added launchpad theme to ui-blocks #35

merged 5 commits into from Oct 21, 2022

Conversation

ashishthakur913
Copy link
Contributor

@ashishthakur913 ashishthakur913 commented Oct 12, 2022

Adds new theme for the new launchpad UI.
Makes changes to UI components to align with the design:

@ashishthakur913 ashishthakur913 marked this pull request as draft October 12, 2022 13:04
.storybook/preview.tsx Outdated Show resolved Hide resolved
@ashishthakur913 ashishthakur913 changed the title feat: added metafinance theme to ui-blocks feat: added launchpad theme to ui-blocks Oct 18, 2022
@ashishthakur913 ashishthakur913 marked this pull request as ready for review October 18, 2022 14:41
Copy link
Member

@MehdiRaash MehdiRaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think as a suggestion, we can define a base theme file which by default can be imported into each component, instead of repeating styles. (I know we have previously imported some styles form blue them, which doesn't sounds a good plan) :

// instead of below code:
export const BUTTON: Record<ButtonVariant, CSSPropertiesExtended> = {
  primary: {
    ...TYPOGRAPHY.btn,
    display: 'flex',
    fontFamily: "'Poppins', sans-serif",
    lineHeight: '24px',
    color: COLOR.light,
    background: COLOR.brandMain,
    border: 0,
    borderRadius: RADIUS.l,
    padding: '12px 16px',
    transition: 'all 0.3s',
    cursor: 'pointer',
....
// we can have:
export const BUTTON: Record<ButtonVariant, CSSPropertiesExtended> = {
  primary: {
    ...TYPOGRAPHY.btn,
    ...BASE.BUTTON,
...

@wahidrahim wahidrahim merged commit 248586d into main Oct 21, 2022
@wahidrahim wahidrahim deleted the ACORN-935 branch October 21, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants