Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove references to FC #37

Merged
merged 28 commits into from Oct 26, 2022
Merged

fix: remove references to FC #37

merged 28 commits into from Oct 26, 2022

Conversation

wahidrahim
Copy link
Contributor

Latest React no longer gives children prop as part of FC.

This results in lint errors in the editor, for example:

CleanShot 2022-10-26 at 14 36 10@2x

This fix removes all FC references and uses PropsWithChildren instead, to deliberately type component props to have children where needed.

@wahidrahim wahidrahim merged commit f97aefd into main Oct 26, 2022
@wahidrahim wahidrahim deleted the remove-references-to-FC branch October 26, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants