Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Update lit-html kitchen-sink benchmark to use real directives #1291

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

justinfagnani
Copy link
Collaborator

This also moves some non-rendering work out of measurements and makes measurements easier to profile.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2020

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -5% - +4% (-1.99ms - +1.49ms)
    this-change vs tip-of-tree

render

  • lit-element-stub1: unsure 🔍 -3% - +5% (-0.78ms - +1.28ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -5% - +2% (-2.23ms - +0.86ms)
    this-change vs tip-of-tree

update

  • lit-html-kitchen-sink: faster ✔ 1% - 6% (0.68ms - 6.75ms)
    this-change vs tip-of-tree

Results

lit-element-stub1
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
25.92ms - 27.22ms-unsure 🔍
-3% - +5%
-0.78ms - +1.28ms
faster ✔
21% - 27%
7.06ms - 9.62ms
tip-of-tree
tip-of-tree
25.52ms - 27.12msunsure 🔍
-5% - +3%
-1.28ms - +0.78ms
-faster ✔
21% - 28%
7.23ms - 9.94ms
previous-release
previous-release
33.81ms - 36.01msslower ❌
26% - 37%
7.06ms - 9.62ms
slower ❌
27% - 38%
7.23ms - 9.94ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
46.47ms - 48.42ms-unsure 🔍
-5% - +2%
-2.23ms - +0.86ms
faster ✔
18% - 22%
10.29ms - 13.32ms
tip-of-tree
tip-of-tree
46.93ms - 49.33msunsure 🔍
-2% - +5%
-0.86ms - +2.23ms
-faster ✔
16% - 21%
9.44ms - 12.79ms
previous-release
previous-release
58.08ms - 60.42msslower ❌
21% - 28%
10.29ms - 13.32ms
slower ❌
19% - 27%
9.44ms - 12.79ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
107.20ms - 110.83ms-faster ✔
1% - 6%
0.68ms - 6.75ms
faster ✔
8% - 13%
10.17ms - 16.08ms
tip-of-tree
tip-of-tree
110.30ms - 115.17msslower ❌
1% - 6%
0.68ms - 6.75ms
-faster ✔
5% - 10%
6.03ms - 12.77ms
previous-release
previous-release
119.80ms - 124.47msslower ❌
9% - 15%
10.17ms - 16.08ms
slower ❌
5% - 11%
6.03ms - 12.77ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
36.13ms - 38.54ms-unsure 🔍
-5% - +4%
-1.99ms - +1.49ms
faster ✔
6% - 16%
2.55ms - 6.93ms
tip-of-tree
tip-of-tree
36.33ms - 38.84msunsure 🔍
-4% - +5%
-1.49ms - +1.99ms
-faster ✔
6% - 16%
2.27ms - 6.71ms
previous-release
previous-release
40.25ms - 43.91msslower ❌
7% - 19%
2.55ms - 6.93ms
slower ❌
6% - 18%
2.27ms - 6.71ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani merged commit ac3804d into lit-next Sep 21, 2020
@justinfagnani justinfagnani deleted the lit-next-benchmark-update branch September 21, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants