Don't use export * to workaround rollup bug #556
Conversation
src/lit-html.ts
Outdated
| export * from './lib/template-factory.js'; | ||
| export {DefaultTemplateProcessor, defaultTemplateProcessor} from './lib/default-template-processor.js'; | ||
| export {Directive, directive, isDirective} from './lib/directive.js'; | ||
| export {isCEPolyfill, removeNodes, reparentNodes} from './lib/dom.js'; |
There was a problem hiding this comment.
remove isCEPolyfill
src/lit-html.ts
Outdated
| export * from './lib/template-factory.js'; | ||
| export {DefaultTemplateProcessor, defaultTemplateProcessor} from './lib/default-template-processor.js'; | ||
| export {Directive, directive, isDirective} from './lib/directive.js'; | ||
| export {isCEPolyfill, removeNodes, reparentNodes} from './lib/dom.js'; |
There was a problem hiding this comment.
Add TODO(justinfagnani): remove line, so that when we get NodePart moving methods we don't export these.
src/lit-html.ts
Outdated
| export {templateCaches, templateFactory} from './lib/template-factory.js'; | ||
| export {TemplateInstance} from './lib/template-instance.js'; | ||
| export {SVGTemplateResult, TemplateResult} from './lib/template-result.js'; | ||
| export {createMarker, isTemplatePartActive, lastAttributeNameRegex, marker, markerRegex, nodeMarker, rewritesStyleAttribute, Template} from './lib/template.js'; |
There was a problem hiding this comment.
remove lastAttributeNameRegex, marker, markerRegex, nodeMarker, rewritesStyleAttribute
|
Has this update made it into a release somewhere? Would love to have this available in my build. |
|
I just came across this same error. Great to see a solution already implemented, can't wait for the release! |
|
@justinfagnani is there anyway we could get a bug fix release on this? Even if it wasn't the right answer long term, this proves to be a pretty big blocker to my team moving forward with a number of projects. It seems like the "fix" at the polymer-cli level either isn't working or isn't going to be released, and the conversation at the RollUp level is still ongoing, so any help you could provide at this level via bug fix release or "next" release or what not would be greatly appreciated. |
|
lit-html 0.13.0 now released. |
* Don't use export * to workaround rollup bug * Don't export internals
No description provided.