Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up getHTML #690

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Speed up getHTML #690

merged 2 commits into from
Dec 20, 2018

Conversation

jridgewell
Copy link
Contributor

@stramel
Copy link
Contributor

stramel commented Dec 12, 2018

👍 LGTM, Ran this on different browsers on my machine.

Just for other people's reference, the results below were top 5 of each run in each browser.

Chrome 71: 1, 4, 7, 2, 3
Firefox 64: 1, 4, 2, 5, 7
Edge 42: 1, 2, 3, 5, 4
Opera 57: 1, 4, 7, 2, 3

Option 1 well exceeded all other options on all browsers except Firefox where most of the options performed well.

@justinfagnani justinfagnani merged commit 6bd0e20 into lit:master Dec 20, 2018
@justinfagnani
Copy link
Collaborator

Awesome :)

@jridgewell jridgewell deleted the faster-getHtml branch December 20, 2018 01:03
@justinfagnani justinfagnani mentioned this pull request Jan 2, 2019
Closed
neuronetio pushed a commit to neuronetio/lit-html that referenced this pull request Dec 2, 2019
@jridgewell @justinfagnani
Speed up getHTML (lit#690)
787cb81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jridgewell @stramel @justinfagnani