polymer-build breaks the app-storage/app-indexeddb-mirror element #1182

abdonrd · 2016-08-05T17:19:29Z

Description

polymer-build breaks the app-storage/app-indexeddb-mirror element.

Versions & Environment

polymer-build: v0.13.0
node: v6.3.0
Operating System: OS X

Steps to Reproduce

git clone https://github.com/GDGSpain/gdg.es.git

npm install && bower install

gulp polymer-build

polymer serve build/bundled

Open the localhost:8080/groups page.

Expected Results

Achieved with the polymer serve.

Actual Results

The text was updated successfully, but these errors were encountered:

abdonrd · 2016-08-16T16:44:23Z

@FredKSchott have been able to review it? Thanks in advance!

FredKSchott · 2016-08-26T18:19:16Z

@abdonrd sorry I still haven't been fix the problem you're seeing with that element. I'll try to find some time next week but I can't promise I'll be able get to it :(

Have you tried digging into the build command yourself? Try using the --verbose flag & maybe adding some logging of your own, you might be able to spot something that I missed when I first looked into this.

abdonrd · 2016-09-21T07:52:47Z

@FredKSchott If I add app-indexeddb-mirror-worker.js and common-worker-scope.js in the includeDependencies works in the unbundled version.

"includeDependencies": [
  "bower_components/app-storage/app-indexeddb-mirror/app-indexeddb-mirror-worker.js",
  "bower_components/app-storage/app-indexeddb-mirror/common-worker-scope.js",
  "bower_components/webcomponentsjs/webcomponents-lite.min.js",
  "LICENSE.txt",
  "app.yaml",
  "manifest.json"
]

But still it is broken in the bundled version. 😔

PS: No errors with --verbose flag.

FredKSchott · 2016-09-23T23:37:30Z

Fixed by GDGSpain/gdg.es#34
We'll be fixing this more generally by outputting these errors. Tracking here: https://github.com/Polymer/polymer-build/issues/52

abdonrd · 2016-09-24T00:36:14Z

Comment at GDGSpain/gdg.es#34 (comment)

FredKSchott · 2016-09-24T00:44:17Z

Oof, okay reopening

abdonrd · 2016-10-06T09:14:02Z

@FredKSchott the new polymer-analyzer will solve this problem? Thanks in advance!

FredKSchott · 2016-11-02T00:28:52Z

@abdonrd the new analyzer was added in v0.5.0, can you download the latest version from npm and see if that fixes it? Fingers crossed for you...

FredKSchott · 2016-11-02T00:34:48Z

Otherwise, please update your steps to reproduce (currently getting Error: File not found with singular glob: /Users/fschott/Code/gdges/app.yaml) and I'll take a look.

abdonrd · 2016-11-02T00:58:12Z

Thanks @FredKSchott! 🙏

I has updated develop branch fixing this error.

abdonrd · 2016-11-02T01:21:02Z

Right now, the behaviors (with your GDGSpain/gdg.es#34) break the build:

FredKSchott · 2016-11-02T01:35:12Z

You are seeing that output on my #34 branch? Hmm… That's strange because
that's exactly what that branch is supposed to fix.

Will take a look first thing tomorrow morning
On Tue, Nov 1, 2016 at 6:21 PM Abdón Rodríguez Davila <
notifications@github.com> wrote:

Right now, the behaviors (with your GDGSpain/gdg.es#34
GDGSpain/gdg.es#34) break the build:

[image: screen shot 2016-11-02 at 02 20 31]
https://cloud.githubusercontent.com/assets/1007051/19913451/fe5df6b8-a0a2-11e6-9f9e-0f636feadfa1.png

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/Polymer/polymer-build/issues/22#issuecomment-257746627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAl-kxK6aX8NzGEfMQ8vQGoKDnHAU2keks5q5-WAgaJpZM4Jd4vu
.

abdonrd · 2016-11-02T01:38:53Z

Yes, I have your branch with extra changes (GDGSpain/gdg.es#43).

FredKSchott · 2016-11-02T16:32:32Z

Okay I dug in a bit today, and uglify is stripping out comments in your build process. Because of this the analyzer isn't able to find the @polymerBehavior tag that it needs to parse.

So the quick fix is to remove JS minification from the build process for now. My copy of gdg.es builds when that step is removed.

I've tried adding uglify back in with the {preserveComments: 'all'} option, but it's still having trouble with extended behaviors (* & *Impl). I'll keep looking into it, it looks like it might be a problem in the new analyzer.

abdonrd · 2016-11-02T17:32:57Z

Thanks @FredKSchott!

Anyway, even disabling the uglify (the npm run build works for me too), the original problem persists. You can check it in https://github.com/GDGSpain/gdg.es/pull/43/files

Chrome:

Safari:

FredKSchott · 2016-11-10T23:16:14Z

So I've looked into this again and I don't think there's anything wrong in build/analyzer now. This might just be a problem between firebase/app-storage elements and bundling.

Can you reduce this down to the smallest reproducible test case? It would be great if we could find out what exactly is breaking on the groups page without the complexity of the rest of your app. That will help us track down and fix this issue as quickly as possible.

abdonrd · 2016-11-15T19:56:18Z

@FredKSchott tell me if it works for you: abdonrd/polymer-build-app-storage-issue :)

midesweb · 2016-11-17T12:43:15Z

for me worked with "includeDependencies" as @abdonrd says, both bundled and unbundled builds

motss · 2016-11-17T12:53:56Z

@abdonrd @FredKSchott @midesweb This is how I resolve this issue - to include the .js files inside app-storage/app-indexeddb-mirror for both bundled and unbundled.

  "sourceGlobs": [
   "src/**/*",
   "images/**/*",
   "bower.json",
   "bower_components/app-storage/app-indexeddb-mirror/*.js"
  ],

abdonrd · 2016-11-18T11:51:42Z

@midesweb @motss but it doesn't work in Safari.

And we shouldn't have to add that in the manifest.json. It should be polymer-build work to find it.

n1ywb · 2016-11-30T16:28:04Z

I think this is related PolymerElements/app-storage#78 and notwaldorf/mojibrag#49

abdonrd · 2016-12-02T11:06:17Z

@FredKSchott have you been able to review the https://github.com/Polymer/polymer-build/issues/22#issuecomment-260749112?

fairsayan · 2017-02-06T18:28:31Z

I tried both @motss and @n1ywb solutions with bundled option: it works only on Chrome. With Firefox and Safari I got errors and basically I never obtain the "App IndexedDB Client connected!" message :-(
Here Safari error:

Looking forward to have this feature fixed.

fairsayan · 2017-02-06T20:28:08Z

PS: I also tried a mix between the 2 solutions, since I realized ./src/common-worker-scope.js doesn't exists, but I fixed it just on Safari (and Chrome 56.0 on my Mac as I wrote before). Here the error on Chrome 55.0 on Android 4.4.2 for the bundled version:

it says the file doesn't exists even if I can get it using wget https://by-wink-timeshift.firebaseapp.com/bower_components/app-storage/app-indexeddb-mirror/common-worker-scope.js?https://by-wink-timeshift.firebaseapp.com/bower_components/app-storage/app-indexeddb-mirror/app-indexeddb-mirror-worker.js

Chrome 55.0 on Android 4.4.2 for the unbundled version works fine with my last dirty fixes.

abdonrd · 2017-03-30T16:38:23Z

@FredKSchott any news? :)

kownacki · 2017-06-08T18:41:19Z

I got this problem because of my service worker. I'm pretty sure you also have one and it also is the cause for you. I solved this problem by adding this to sw-precache-config.js:

ignoreUrlParametersMatching: [/^<your origin here>/]

So for example for @abdonrd it would be:

ignoreUrlParametersMatching: [/^https:\/\/gdg-es-develop\.firebaseapp\.com/]

Of course, as you already found out, it's also required to add this to polymer.json:

"extraDependencies": [
  "bower_components/app-storage/app-indexeddb-mirror/app-indexeddb-mirror-worker.js",
  "bower_components/app-storage/app-indexeddb-mirror/common-worker-scope.js"
]

Explanation

As it's written here

sw-precache finds matching cache entries by doing a comparison with the full request URL

So https://gdg-es-develop.firebaseapp.com/bower_components/app-storage/app-indexeddb-mirror/common-worker-scope.js?https://gdg-es-develop.firebaseapp.com/bower_components/app-storage/app-indexeddb-mirror/app-indexeddb-mirror-worker.js because of this crazy parameter it couln't find this URL among the precached and so it returned 404.

For me it should be at least noted in the app-storage documentation like it's noted about extraDependencies link

Or it should be redesigned to avoid problems like this at all.

abdonrd · 2017-06-08T18:54:08Z

Thanks @kownacki!

I update with some info from GDGSpain/gdg.es#32 (comment):

After:

Update app-storage to v1.0.0

Update polymer-build to v1.0.0

Add app-storage extraDependencies in the polymer.json

Works in Chrome and Firefox! 🎉

But it still does not work on Safari.

kownacki · 2017-06-08T18:58:24Z

@abdonrd It is enough to make it working in desktop browsers where Shared Workers are available. But app-storage on android switches to Web Workers which causes more problems which can be solved with ignoreUrlParametersMatching.

I hope it helps :)

abdonrd · 2017-06-14T12:52:02Z

@kownacki I has tried what you said at https://github.com/Polymer/polymer-build/issues/22#issuecomment-307191630, but in Safari (macOS) continues to fail.

Btw, Safari doesn't have SW support. Then the sw-precache-config.js doesn't affect.

kownacki · 2017-06-14T13:37:07Z

@abdonrd If there is no Service Worker then I see no other option than that this this file is simply not available on the server, thus 404. You noticed that it happens only on the bundled version. I don't bundle my code with polymer-build. There must be still something wrong with the bundle process.

abdonrd · 2017-06-14T13:40:06Z

@kownacki yes, before the build it works:

andreataglia · 2017-12-23T21:55:57Z

@kownacki your solution works for me! Thanks a lot!

abdonrd · 2019-07-18T15:02:23Z

Closing and old issue.

FredKSchott closed this as completed Sep 23, 2016

FredKSchott reopened this Sep 24, 2016

aomarks transferred this issue from Polymer/polymer-build Jan 3, 2019

aomarks added the Package: build label Jan 3, 2019

abdonrd closed this as completed Jul 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

polymer-build breaks the app-storage/app-indexeddb-mirror element #1182

polymer-build breaks the app-storage/app-indexeddb-mirror element #1182

abdonrd commented Aug 5, 2016

abdonrd commented Aug 16, 2016

FredKSchott commented Aug 26, 2016

abdonrd commented Sep 21, 2016 •

edited

FredKSchott commented Sep 23, 2016

abdonrd commented Sep 24, 2016

FredKSchott commented Sep 24, 2016

abdonrd commented Oct 6, 2016

FredKSchott commented Nov 2, 2016

FredKSchott commented Nov 2, 2016

abdonrd commented Nov 2, 2016 •

edited

abdonrd commented Nov 2, 2016

FredKSchott commented Nov 2, 2016

abdonrd commented Nov 2, 2016 •

edited

FredKSchott commented Nov 2, 2016

abdonrd commented Nov 2, 2016 •

edited

FredKSchott commented Nov 10, 2016

abdonrd commented Nov 15, 2016

midesweb commented Nov 17, 2016

motss commented Nov 17, 2016

abdonrd commented Nov 18, 2016

n1ywb commented Nov 30, 2016 •

edited

abdonrd commented Dec 2, 2016

fairsayan commented Feb 6, 2017

fairsayan commented Feb 6, 2017 •

edited

abdonrd commented Mar 30, 2017

kownacki commented Jun 8, 2017

abdonrd commented Jun 8, 2017 •

edited

kownacki commented Jun 8, 2017 •

edited

abdonrd commented Jun 14, 2017

kownacki commented Jun 14, 2017

abdonrd commented Jun 14, 2017

andreataglia commented Dec 23, 2017

abdonrd commented Jul 18, 2019

polymer-build breaks the app-storage/app-indexeddb-mirror element #1182

polymer-build breaks the app-storage/app-indexeddb-mirror element #1182

Comments

abdonrd commented Aug 5, 2016

Description

Versions & Environment

Steps to Reproduce

Expected Results

Actual Results

abdonrd commented Aug 16, 2016

FredKSchott commented Aug 26, 2016

abdonrd commented Sep 21, 2016 • edited

FredKSchott commented Sep 23, 2016

abdonrd commented Sep 24, 2016

FredKSchott commented Sep 24, 2016

abdonrd commented Oct 6, 2016

FredKSchott commented Nov 2, 2016

FredKSchott commented Nov 2, 2016

abdonrd commented Nov 2, 2016 • edited

abdonrd commented Nov 2, 2016

FredKSchott commented Nov 2, 2016

abdonrd commented Nov 2, 2016 • edited

FredKSchott commented Nov 2, 2016

abdonrd commented Nov 2, 2016 • edited

FredKSchott commented Nov 10, 2016

abdonrd commented Nov 15, 2016

midesweb commented Nov 17, 2016

motss commented Nov 17, 2016

abdonrd commented Nov 18, 2016

n1ywb commented Nov 30, 2016 • edited

abdonrd commented Dec 2, 2016

fairsayan commented Feb 6, 2017

fairsayan commented Feb 6, 2017 • edited

abdonrd commented Mar 30, 2017

kownacki commented Jun 8, 2017

abdonrd commented Jun 8, 2017 • edited

kownacki commented Jun 8, 2017 • edited

abdonrd commented Jun 14, 2017

kownacki commented Jun 14, 2017

abdonrd commented Jun 14, 2017

andreataglia commented Dec 23, 2017

abdonrd commented Jul 18, 2019

abdonrd commented Sep 21, 2016 •

edited

abdonrd commented Nov 2, 2016 •

edited

abdonrd commented Nov 2, 2016 •

edited

abdonrd commented Nov 2, 2016 •

edited

n1ywb commented Nov 30, 2016 •

edited

fairsayan commented Feb 6, 2017 •

edited

abdonrd commented Jun 8, 2017 •

edited

kownacki commented Jun 8, 2017 •

edited