-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--js-compile --js-minify --html-minify make jQuery crash #2382
Comments
Might be related to babel/babel#340 BTW, why to use jQuery with Polymer? You might not need it at all, and take into account that in case of DOM manipulations, jQuery is not aware of Shadow DOM. |
I'm trying to build a SaaS application wtihout jQuery, But some thirdpart library not sure. such as: http://www.highcharts.com, https://www.mobiscroll.com 😪. |
@baocang Can you try each of those flags individually, to see which is causing the issue? My guess is it's just We have a task to add the ability to whitelist files to be skipped for processing. If some popular files are currently broken we should bump up the priority. |
@FredKSchott --bundle --js-minify. |
@FredKSchott |
Okay, thanks for responding with that info. I'll look into this when I can prioritize the time. |
Any news to this? |
For the time being - submitted a PR to skip problematic js files here : Polymer/polymer-cli#878. Try it out by adding jQuery in the list of files to skip. |
this is now fixed in my babel minfy patch: babel/minify#733 I put a suggestion how to use while babel minify is not updated (and polymer cli also not) here: https://github.com/Polymer/polymer-cli/issues/886 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Versions & Environment
Steps to Reproduce
polymer init polymer-2-application
<script src="jquery-3.2.0.js"></script>
#1.0.0-rc.7
bower update
polymer build --entrypoint index.html --shell src/app-shell/app-shell.html --bundle --js-compile --js-minify --html-minify
polymer serve build/default
Expected Results
No error is throw
Actual Results
Error is thrown
The text was updated successfully, but these errors were encountered: