Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resulting HTML File is Broken, \0 is replaced by NUL Character #2529

Open
jogibear9988 opened this issue Sep 24, 2017 · 6 comments
Open

Resulting HTML File is Broken, \0 is replaced by NUL Character #2529

jogibear9988 opened this issue Sep 24, 2017 · 6 comments

Comments

@jogibear9988
Copy link

  • Polymer CLI: 1.5.5
  • node: 8.4.0
  • Operating System: Windows

I've compiled a website via

polymer build --verbose --bundle --js-minify --css-minify --html-minify --root ..\HTML\

problem is, I use jquery on my page. Jquery contains following Line:

  identifier = "(?:\\\\.|[\\w-]|[^\0-\\xa0])+",

in this line \0 is replaced by "NUL" char. so the resulting file will not work!

@jogibear9988 jogibear9988 changed the title Resulting HTML File is Broken, \0 is replaced by NUL Chracter Resulting HTML File is Broken, \0 is replaced by NUL Character Sep 24, 2017
@jogibear9988
Copy link
Author

think it's this error: https://github.com/Polymer/polymer-cli/issues/633

@jogibear9988
Copy link
Author

If I'll remove "--js-minify" it works, but file is 10 times the size...

@jogibear9988
Copy link
Author

should be fixed when babel/minify#733 is merged and after that babel/minify is updated!

@jogibear9988
Copy link
Author

I now use my patched Version of babel minify like this:

call npm i polymer-cli
call git clone https://github.com/jogibear9988/minify.git
cd minify
call git fetch
call git checkout patch-1
call npm i
call gulp
cd ..
for /f %%d IN ('dir /ad /b minify\packages') DO ( call npm i minify\packages\%%d )

@usergenic
Copy link
Contributor

cc @usergenic since you're looking at the updates to exclude some files from minification etc.

@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants