Windows fixes #199
Windows fixes #199
Conversation
|
Not ready for review yet. 3 tests still failing. |
|
You should fix on github.ts too. It has path problem in windows, all the files ignored for being extracted. |
|
I know. First step is to get ask existing tests passing. |
justinfagnani
force-pushed
the
windows
branch
2 times, most recently
from
e9742aa
to
ae1e6bb
Compare
|
@FredKSchott ready for review now! |
| if (file) { | ||
| deferred.resolve(file.contents.toString()); | ||
| } else { | ||
| throw new Error(`No file found for ${filepath}`); |
There was a problem hiding this comment.
I did that and it ended up being wrong because Hydrolysis actually rejects... I left the line in commented out with a comment not to add it back :)
|
Looking good, a few small comments |
|
@tennosys would love your feedback as well if you have a chance to check out this branch and confirm that it fixes any bugs you were seeing. |
| let url = this.urlFromPath(fragment) | ||
| let file = this.files.get(url); | ||
| if (file == null) { | ||
| throw new Error(`no file found for fragment ${fragment}`); |
There was a problem hiding this comment.
throw error or done(error)?
I know, These are annoying :)
|
LGTM! Lets definitely test this in all of our major workflows / give it some time to bake before releasing to npm. |
justinfagnani
force-pushed
the
windows
branch
2 times, most recently
from
b82cf4c
to
ce25cf0
Compare
No description provided.