This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
added configFile argv for WCT. #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hvdb! I'll try to take a look at this and Polymer/web-component-tester#388 as soon as possible (The team is busy getting ready for Polymer Summit next week so it might be a little while before I can) |
FredKSchott
suggested changes
Apr 13, 2017
There was a problem hiding this comment.
@hvdb now that Polymer/web-component-tester#388 is merged I'm happy to start reviewing this with you.
For this to work properly we'll need to wait for a new release of WCT though, and then pin to that latest version in our package.json.
| @@ -104,6 +104,11 @@ export class TestCommand implements Command { | |||
| description: "Set job visibility to 'public', 'public restricted', 'share', 'team' or 'private'", | |||
| type: String, | |||
| }, | |||
| { | |||
| name: 'configFile', | |||
There was a problem hiding this comment.
all cli flags have followed the dash-case format, please change to config-file and handle the mapping into WCT below.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: Polymer/web-component-tester#388